modrinth-app-unwrapped: fix build, 0.10.3 -> 0.10.5

[gepbird]

ZHF: #457852

Relases:

• https://github.com/modrinth/code/releases/tag/v0.10.5
  • fixes rust build: Update Rust dependencies modrinth/code#4139
  • requires some env vars to be present when building the rust part, we can reuse .env.local
• 0.10.4 was pulled, diff: modrinth/code@v0.10.3...v0.10.4

This is not the latest version, just the earliest one to fix the build.

cc @typedrat (#462979 (comment))

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[gepbird]

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 463705
Commit: 1cfc956f8d3fd857efa2b3d0a11e3642aca0bff6 (subsequent changes)
Merge: b0bd8fe6c7b681ade07a3c99b793c91588f62b80

Logs: https://github.com/gepbird/nixpkgs-review-gha/actions/runs/19567433212

Download packages from cache:

• x86_64-linux

  nix-store -r --add-root nixpkgs-pr-463705-x86_64-linux \
    --option binary-caches 'https://cache.nixos.org/ https://gepbird-nixpkgs-review-gha.cachix.org' \
    --option trusted-public-keys '
    cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
    gepbird-nixpkgs-review-gha.cachix.org-1:DXx7aJqJyRfrgSacf/SSVzEaPbrH3lych7ti/zUBol4=
    ' \
    /nix/store/bikl8q2y5qzxw2vv1wms2lb1v6cch81q-modrinth-app-unwrapped-0.10.5 \
    /nix/store/iymkvq6pqwzy4ygqlx9cdq4n2s6r7fyr-modrinth-app-0.10.5

---

x86_64-linux

✅ 2 packages built:

• modrinth-app
• modrinth-app-unwrapped

---

aarch64-linux

✅ No rebuilds

---

x86_64-darwin (sandbox = relaxed)

❌ 2 packages failed to build:

• modrinth-app
• modrinth-app-unwrapped

---

aarch64-darwin (sandbox = relaxed)

❌ 2 packages failed to build:

• modrinth-app
• modrinth-app-unwrapped

[Hythera]

Tested on x86_64-linux, most features like log-in, creating and starting a modpack work. Downloading mods and other content doesn't (because of the mentioned missing env vars). Java fails to download and isn't picked up by default. :)

[gepbird]

Tested on x86_64-linux, most features like log-in, creating and starting a modpack work. Downloading mods and other content doesn't (because of the mentioned missing env vars). Java fails to download and isn't picked up by default. :)

Thanks, that's very helpful! That sounds better than it being broken.

In the future I plan to maintain this (and use it regularly, I'm still on Prism) :)

[Hythera]

(non-blocking) Everything seems to work for me now. I only ran into two issues. Firstly jumping into worlds doesn't work from the home page (only from the modpack page), this will probably be fixed by updating the launcher to a newer version. Secondly the launcher is not able to download its own java installation (there are some issues relating that on modrinth's repository).

JRE error: Could not check Java version at path /home/username
/.local/share/ModrinthApp/meta/java_versions/zulu21.46.19-ca-jre21.0.9-linux_x64/bin/java

Setting the java path manually fixes this.

Edit: I tried updating the package locally to 0.10.20 and it works without any extra steps. This also fixes issue 1.

[mdaniels5757]

FYI: v0.10.21 is now out (https://github.com/modrinth/code/releases).

I see that you mentioned that you had only updated as little as possible in order to fix the build. May I ask why? Normally I try to update as much as possible in this situation (where the stable branch has never had a working build, so breaking changes are not an issue).

[gepbird]

Feel free to update it to the latest. I did not hane the capacity to read through all those changes, possibly encounter and fix other issues. Plus a smaller change could be easier and faster to review.

[mdaniels5757]

Fair enough, I just thought that I should mention it, since Hythera above reported that 0.10.20 fixed some issues they had (and they didn't say it needed any changes other then version/hashes)

[nixpkgs-ci]

Successfully created backport PR for release-25.11:

• [Backport release-25.11] modrinth-app-unwrapped: fix build, 0.10.3 -> 0.10.5 #466902