NorESM2.1: Add NorCPM as an ESP component

[blcc]

Hi,
This PR adds NorCPM to Externals.cfg and compsets (NHISTNCPM, NHISTNCPMfrc2).

Thanks,
Ping-Gin

[TomasTorsvik]

@blcc - Looks fine to me.
Do you have write access, can you merge this yourself? Otherwise, I can do this.

[gold2718]

I am really happy NorCPM is getting integrated into the NorESM code base. One thing I think we need to be able to maintain this (and help get it into newer versions of NorESM) is one or more regression test. I can help create the test entries, we just need to specify some information:

• Compset or compsets: E.g., NHISTNCPM, NHISTNCPMfrc2 or both
• Resolution: For testing, is the f19_tn14 grid sufficient?
• Test type: Should this test pass a restart test or just be able to run and reproduce baseline results?
• Test length: How long does the test need to run to fully test the NorCPM features?
• Any special setup (e.g., xmlchange) or run-time (user_nl_<xxx>) modifications?

[blcc]

Hi @gold2718 ,
I updated the PRs (NorESM and cime). Can you have a look?
Thanks,
Ping-Gin

[gold2718]

@blcc, the changes look good. Can you address the testing questions above (in my review notes)?

[blcc]

I am really happy NorCPM is getting integrated into the NorESM code base. One thing I think we need to be able to maintain this (and help get it into newer versions of NorESM) is one or more regression test. I can help create the test entries, we just need to specify some information:

* Compset or compsets: E.g., `NHISTNCPM`, `NHISTNCPMfrc2` or both

Both compsets are supported.

* Resolution: For testing, is the `f19_tn14` grid sufficient?

Yes, it sufficient.
For now NorCPM only modify ocean component. f09_tn14 should be able to run.
However, we can add the "sci. supported" back after more validations.

* Test type: Should this test pass a restart test or just be able to run and reproduce baseline results?

The test is from startup run. And it can do continue run, reproduce identical results.

* Test length: How long does the test need to run to fully test the NorCPM features?

Since NorCPM assimilate daily SST and monthly temperature and salinity profile.
Technical test can be only 1 month. For scientific validations, it will be good to have 20 model year test.

* Any special setup (e.g., `xmlchange`) or run-time (`user_nl_<xxx>`) modifications?

It is necessary to change the NINST and NTASKS in case. I'm still working on the document.

[blcc]

@gold2718
Hi, I updated the README.md with an test script in norcpm_esp repo.
Do you think it is sufficient for current state?

[gold2718]

@gold2718 Hi, I updated the README.md with an test script in norcpm_esp repo. Do you think it is sufficient for current state?

I am not sure what I am looking for. I see slightly different files:

• From: BjerknesCPU
• From: NorESMhub

Which one should I refer to? The BjerknesCPU version seems to have more information but NorESM pulls from NorESMhub. I need to have enough information to add a regression test so that the NorCPM test gets run on a regular basis.

[blcc]

@gold2718
You're right. I should keep only one of them.
I'll remove the BjerknesCPU one later.

I am not sure what I am looking for. I see slightly different files:

* From: [BjerknesCPU](https://github.com/BjerknesCPU/norcpm_esp/blob/main/README.md)

* From: [NorESMhub](https://github.com/NorESMhub/norcpm_esp/blob/main/README.md)

Which one should I refer to? The BjerknesCPU version seems to have more information but NorESM pulls from NorESMhub. I need to have enough information to add a regression test so that the NorCPM test gets run on a regular basis.

[gold2718]

@blcc
What version of CIME are you using? I keep getting errors when trying to run a case with NorCPM.

[blcc]

@gold2718
This is strange. I'll test again to see what happened.

[blcc]

@gold2718
I fixed few typo in test script.
And it need the PR of cime
NorESMhub/cime#83
Which add NorCPM as to one of the ESP component in cime/config/config_files.xml.

[gold2718]

@blcc, I have made updates to CIME and NorESM but am having trouble getting the ESP component to build.
Please see the test directory, /cluster/work/users/goldy/work/norcpm/test_prealpha_noresm_2024_11_15/SMS_C2_D_Ld2.f19_tn14.NHISTNCPM.betzy_intel.allactive-norcpm.GC.20241115_133400_stpt9i

[blcc]

@gold2718 , I cannot cd to norcpm directory in the path. I see the permission is only for read, not for enter.

[gold2718]

@gold2718 , I cannot cd to norcpm directory in the path. I see the permission is only for read, not for enter.

Sorry about that. I have opened both that directory tree and the associated source tree (/cluster/projects/nn9560k/goldy/NorESM21)

[blcc]

@gold2718
I tried the NorESM21 you provided to create and run, seems no problem.
Here is my create/build/run script:
/cluster/projects/nn9039k/people/pgchiu/NorESM_git/test_for_git/create_norcpm_esp.sh
The case dir is at same directory.

And I still cannot access your test case. The permission shows that:
drwxr-sr-- 4 goldy goldy 4096 Nov 15 13:34 /cluster/work/users/goldy/work/norcpm

[blcc]

@gold2718 ,
I think the error is due to the NTASKS.
For current setup, the NTASKS must be NTASKS_PER_INST * NINST.
In this case, the NTASKS_OCN is 126 for 63 cpus per BLOM instances. And so does other component.
Ping-Gin

[gold2718]

I got further, however, when linking, came across this undefined reference:

/cluster/projects/nn9560k/goldy/NorESM21/components/norcpm/assim_example/EnKF/m_insitu.F90:436: undefined reference to `get_mod_fld_new_'

Any idea where this function is and why the build did not find it (I can not find it in my source tree)?

[blcc]

@gold2718
I got it. It is a bug.
The get_mod_fld_new() is in a if-block which is always FALSE.
When compiler compile with optimization, the whole if-block will be removed. Then no error occurred, which is my situation.
However it is still a bug. I put a new version of m_insitu.F90 in components/norcpm/noresm. It should be able to override old one.

Thanks,
Ping-Gin

[blcc]

Seems obsoleted.