Open
Conversation
gold2718
requested changes
Sep 28, 2024
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This PR needs a few tweaks. Also, please think about if NorCPM needs any help with archiving. For instance, the short-term archiver (<cime>/scripts/lib/CIME/case/case_st_archive.py) has to know which files to save after a successful run.
See especially <cime>/config/cesm/config_archive.xml where you can add filename patterns to look for and save.
We may need to tweak a couple of other files as well. We can figure that out after we have a test in NorESMhub/NorESM#565.
Author
|
@gold2718 thanks. |
Author
|
@gold2718 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR add NorCPM as an ESP component.
It's won't effect any exist configuration.
Thanks,
Ping-Gin