-
-
Notifications
You must be signed in to change notification settings - Fork 784
[13.0][IMP] account: Add progressbar to _move_model_in_data #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 13.0
Are you sure you want to change the base?
Conversation
|
As the progress-bar thing can take some time to be discussed, we can extract that commit to a separate PR if you consider so for speeding up the rest. |
|
login: andrew I try to migrate DB that above. |
|
@kos94ok-3D that has nothing to do with this patch. I have migrated already 3 DBs with this patch (and without) and invoices are shown. |
|
Could you try my DB and then check? There only 4 or 5 invoices |
|
I found that post-migration script did not start. I do not understand why. ERROR mig13 odoo.modules.migration: module account: Each post-migration file must have a "migrate(cr, installed_version)" function |
|
Indeed this is the log from Travis as well: https://github.com/OCA/OpenUpgrade/pull/2640/checks?check_run_id=2259629368#step:12:4729 but this is a log from today of a migrated DB with the same PR + openupgradelib modification: |
|
The problem is due to the new decorator doesn't exist yet in the library, then the file fails to load, and gives such error. It's normal in this PR, but in your installation, you must install the library specific from the other PR. |
|
I tried to install openupgradelib from your branch and tried to install the latest from openpgrade with adding your change but it does not work. |
|
Yes, probably, but that's out of the scope of this. Use the recommended version, which is Python 3.6. |
|
I would like to merge this without the first commit, and then, when the openupgradelib PR is merged, assuring it works for several python versions, then you can do another PR to add that decorator. |
|
@MiquelRForgeFlow extracted the performance round in #2643 |
7f90383 to
3c4fc81
Compare
|
Left this one only for the progressbar. |
Requires:
@Tecnativa TT19674