Skip to content

Conversation

@pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Apr 3, 2021

@pedrobaeza pedrobaeza added this to the 13.0 milestone Apr 3, 2021
@pedrobaeza
Copy link
Member Author

As the progress-bar thing can take some time to be discussed, we can extract that commit to a separate PR if you consider so for speeding up the rest.

@kos94ok-3D
Copy link

login: andrew
password: 1111
mig_account_v12.zip

I try to migrate DB that above.
I opened invoice customer and vendor bill and see nothing

@pedrobaeza
Copy link
Member Author

@kos94ok-3D that has nothing to do with this patch. I have migrated already 3 DBs with this patch (and without) and invoices are shown.

@kos94ok-3D
Copy link

Could you try my DB and then check? There only 4 or 5 invoices

@kos94ok-3D
Copy link

kos94ok-3D commented Apr 5, 2021

I found that post-migration script did not start. I do not understand why.

ERROR mig13 odoo.modules.migration: module account: Each post-migration file must have a "migrate(cr, installed_version)" function

@pedrobaeza
Copy link
Member Author

Indeed this is the log from Travis as well:

https://github.com/OCA/OpenUpgrade/pull/2640/checks?check_run_id=2259629368#step:12:4729

but this is a log from today of a migrated DB with the same PR + openupgradelib modification:

. . . 
2021-04-05 12:44:38,569 1 �[1;32m�[1;49mINFO�[0m prod odoo.modules.loading: loading account/report/account_hash_integrity_templates.xml 
2021-04-05 12:44:38,579 1 �[1;32m�[1;49mINFO�[0m prod odoo.modules.migration: module account: Running migration [13.0.1.1>] post-migration 
2021-04-05 12:44:38,584 1 �[1;32m�[1;49mINFO�[0m prod OpenUpgrade: account: post-migration script called with version 12.0.1.1 
. . .

@pedrobaeza
Copy link
Member Author

The problem is due to the new decorator doesn't exist yet in the library, then the file fails to load, and gives such error. It's normal in this PR, but in your installation, you must install the library specific from the other PR.

@kos94ok-3D
Copy link

I tried to install openupgradelib from your branch and tried to install the latest from openpgrade with adding your change but it does not work.
Maybe does it not work with python 3.8?

@pedrobaeza
Copy link
Member Author

Yes, probably, but that's out of the scope of this. Use the recommended version, which is Python 3.6.

@MiquelRForgeFlow
Copy link
Contributor

I would like to merge this without the first commit, and then, when the openupgradelib PR is merged, assuring it works for several python versions, then you can do another PR to add that decorator.

@pedrobaeza
Copy link
Member Author

@MiquelRForgeFlow extracted the performance round in #2643

@pedrobaeza pedrobaeza force-pushed the 13.0-account-progressbar branch from 7f90383 to 3c4fc81 Compare April 6, 2021 16:01
@pedrobaeza pedrobaeza changed the title [13.0][FIX+IMP] account: several performance improvements + fix + progressbar visualization [13.0][IMP] account: Add progressbar to _move_model_in_data Apr 6, 2021
@pedrobaeza
Copy link
Member Author

Left this one only for the progressbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants