Skip to content

[13.0][IMP] account: Add progressbar to _move_model_in_data #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrobaeza wants to merge 1 commit into
base: 13.0
Choose a base branch
from
Open

[13.0][IMP] account: Add progressbar to _move_model_in_data #2640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions addons/account/migrations/13.0.1.1/post-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,35 +572,36 @@ def migration_voucher_moves(env):
)


def _move_model_in_data(env, ids_map, old_model, new_model):
@openupgrade.progress()
def _move_model_in_data(env, id_map, old_model, new_model):
renames = [
('mail_message', 'model', 'res_id'),
('mail_followers', 'res_model', 'res_id'),
('ir_attachment', 'res_model', 'res_id'),
('mail_activity', 'res_model', 'res_id'),
('ir_model_data', 'model', 'res_id'),
]
for old_id, new_id in ids_map:
for rename in renames:
query = """
UPDATE {table}
SET {field1} = %(new_value1)s, {field2} = %(new_value2)s
WHERE {field1} = %(old_value1)s AND {field2} = %(old_value2)s"""
if rename[0] == 'mail_followers':
query += """ AND partner_id NOT IN (
SELECT partner_id FROM mail_followers
WHERE res_model = 'account.move' AND res_id = %(new_value2)s
)"""
env.cr.execute(sql.SQL(query).format(
table=sql.Identifier(rename[0]),
field1=sql.Identifier(rename[1]),
field2=sql.Identifier(rename[2])
), {
"old_value1": old_model,
"new_value1": new_model,
"old_value2": old_id,
"new_value2": new_id,
})
old_id, new_id = id_map
for rename in renames:
query = """
UPDATE {table}
SET {field1} = %(new_value1)s, {field2} = %(new_value2)s
WHERE {field1} = %(old_value1)s AND {field2} = %(old_value2)s"""
if rename[0] == 'mail_followers':
query += """ AND partner_id NOT IN (
SELECT partner_id FROM mail_followers
WHERE res_model = 'account.move' AND res_id = %(new_value2)s
)"""
env.cr.execute(sql.SQL(query).format(
table=sql.Identifier(rename[0]),
field1=sql.Identifier(rename[1]),
field2=sql.Identifier(rename[2])
), {
"old_value1": old_model,
"new_value1": new_model,
"old_value2": old_id,
"new_value2": new_id,
})


def fill_account_move_type(env):
Expand Down