[18.0][FIX] don't set install_filename when loading views from openupgrade_scripts #5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @StefanRijnhart, @legalsylvain, |
StefanRijnhart
approved these changes
Nov 7, 2025
legalsylvain
approved these changes
Nov 7, 2025
Contributor
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
Thanks !
makes sense.
/ocabot merge nobump
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 6fc1656. Thanks a lot for contributing to OCA. ❤️ |
Member
|
Isn't this something to do also on 17.0? |
Member
Author
|
yes, probably even older ones |
|
Hi @hbrunn can this be merged into 17.0 too please? Currently trying to upgrade 16->17->18 and 18 can not start because of this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove install_filename from context if it's from openupgrade_scripts.
Without this, arch_fs will point to openupgrade_scripts' file which most likely
won't exist when the migrated database is deployed, which breaks resetting views
see #5437
@remi-filament please verify this fixes your issue for v18, and then cherry pick to v17 without the test