[19.0][MIG] account_financial_report: Migration to 19.0 #1413

micheledic · 2025-11-18T11:51:43Z

No description provided.

micheledic · 2025-11-18T13:52:41Z

@OCA/accounting-maintainers

micheledic · 2025-11-19T07:31:46Z

@pedrobaeza can you add to migration issue? #1393

pedrobaeza · 2025-11-19T07:32:35Z

/ocabot migration account_financial_report

adnankkapasi · 2025-11-21T08:46:21Z

@micheledic
When we export to Xlsx, it is giving traceback.

micheledic · 2025-11-21T10:50:47Z

@micheledic When we export to Xlsx, it is giving traceback.

This is caused by OCA/reporting-engine#1095
Please test the other things , if they won't merge the fix soon, i will add a commit with test-requirement

Currently translated at 75.5% (185 of 245 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-account_financial_report/ro/

Currently translated at 78.0% (191 of 245 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-account_financial_report/ro/

Currently translated at 79.2% (194 of 245 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-account_financial_report/ro/

Currently translated at 100.0% (245 of 245 strings) Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-account_financial_report/es_AR/

Since v14, Odoo defines the `__slots__` attribute in the `BaseModel` class (odoo/odoo@ea3e395) This makes it impossible to add attributes to an instance like it was done here in v13. The use of the `report_data` dictionary passed between method is the closes and simples solution to this "issue". TT26415 Co-authored-by: Alex Cuellar <[email protected]>

On multi-company settings, we need to make sure we are searching and creating objects with the correct company associated. Also take into account previously created account groups TT28423

Use core account test base, helping to ensure we have the correct accounting environment setup. If any of the localization modules are loaded, this will make this tests be skipped, instead of simply failing TT28423

Currently translated at 94.2% (231 of 245 strings) Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-account_financial_report/es/

Currently translated at 0.0% (0 of 245 strings) Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-account_financial_report/es_MX/

Currently translated at 93.4% (229 of 245 strings) Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-account_financial_report/fr/

Currently translated at 100.0% (245 of 245 strings) Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-account_financial_report/es_AR/

This commit both improves perfs by doing a single search() instead of search() + filtered and also make account selection by interval really work.

Fixed warning seen in logs while generating General Ledger Report due to unsupported operand type.

…n there are multiple analytic accounts on single analytic distribution line.

Selecting no value in the "Grouped by" general ledger wizard, but filtering any account, results in an empty display, due to the weird trick of having an empty selection value. This, joined with the fact of not being able to predefine that empty value with standard tools, makes the switch necessary. - Set grouped_by as required with non grouped item description. - Switched selection value from "" (empty) to "none". - Adapt general_ledger group_by conditionals. Co-Authored-By: aritzolea

Currently translated at 100.0% (271 of 271 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/es/

Partial revert of 01f22b8 Adding css in web.assets_backend Affects the display of the Odoo interface Reverts to how it was in v17

Currently translated at 100.0% (271 of 271 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/tr/

It happens because on 18.0 the group_id is not stored so the one2many account_ids is not working

…_group for trial balance On Odoo18 if you group:sum by amount_currency, if you don't put currency_id in the group field the amount_currency is removed by read_group function on account addon

Currently translated at 100.0% (271 of 271 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/sv/

Currently translated at 54.6% (148 of 271 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/ar/

Currently translated at 87.8% (238 of 271 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/ar/

TT49193

Currently translated at 89.7% (245 of 273 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/fr/

Currently translated at 100.0% (273 of 273 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/it/

Currently translated at 100.0% (273 of 273 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/tr/

Currently translated at 66.6% (182 of 273 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/fr_CH/

Currently translated at 89.7% (245 of 273 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/fr_CH/

…t move line in reports Co-Authored-By: Pedro M. Baeza <[email protected]>

Currently translated at 100.0% (275 of 275 strings) Translation: account-financial-reporting-18.0/account-financial-reporting-18.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-18-0/account-financial-reporting-18-0-account_financial_report/it/

If not, most users will have an access error.

micheledic · 2025-11-24T08:11:51Z

@adnankkapasi OCA/reporting-engine#1099 merged. CAn you review my pr ?

pedrobaeza · 2025-12-10T08:18:21Z

Please include #1417, which bug was introduced in 18.0 migration in 01f22b8#diff-260f9ea3aa1ce82c648c78dc37fadbc5a2994d87814123220854711391474b34R146 by @chaule97

Steps to reproduce: - Archive a journal that contains journal entries. - Print a general ledger including at least one of those journal entries. - You get a KeyError: ``` File ".../addons/account_financial_report/models/ir_actions_report.py", line 27, in _render_xlsx return super(IrActionsReport, obj)._render_xlsx(report_ref, docids, data=data) File ".../addons/report_xlsx_helper/models/ir_actions_report.py", line 19, in _render_xlsx return super()._render_xlsx(report_ref, docids, data) File ".../addons/report_xlsx/models/ir_report.py", line 27, in _render_xlsx .create_xlsx_report(docids, data) # noqa File ".../addons/report_xlsx/report/report_abstract_xlsx.py", line 105, in create_xlsx_report self.generate_xlsx_report(workbook, data, objs) File ".../addons/account_financial_report/report/abstract_report_xlsx.py", line 40, in generate_xlsx_report self._generate_report_content(workbook, objects, data, report_data) File ".../addons/account_financial_report/report/general_ledger_xlsx.py", line 287, in _generate_report_content "journal": journals_data[line["journal_id"]]["code"], KeyError: 93 ``` That's because the code of the journals are fetched with a search without active_test=False context, so archived journals are not taken into account, and when later trying to get the information, failing. The solution is to pass the context for getting all the journals, including archived ones. TT59739

micheledic · 2025-12-10T08:50:14Z

Please include #1417, which bug was introduced in 18.0 migration in 01f22b8#diff-260f9ea3aa1ce82c648c78dc37fadbc5a2994d87814123220854711391474b34R146 by @chaule97

done!

micheledic · 2026-01-13T10:26:08Z

@OCA/accounting-maintainers ping

micheledic force-pushed the 19.0_mig_account_financial_report branch 5 times, most recently from e6b3fa4 to 028a608 Compare November 18, 2025 13:48

micheledic mentioned this pull request Nov 18, 2025

Migration to version 19.0 #1393

Open

4 tasks

OCA-git-bot added this to the 19.0 milestone Nov 19, 2025

micheledic mentioned this pull request Nov 21, 2025

[18.0][FIX] report_xlsx OCA/reporting-engine#1095

Merged

JoanSForgeFlow and others added 17 commits November 24, 2025 08:39

[ADD] domain field for additional filtering

bd4a119

[IMP] domain widget performance fix

09b8fa0

[FIX] General ledger XLSX: solved mistake in the info

2c8b9f8

[UPD] Eficent -> ForgeFlow

e95b242

[IMP] account_financial_report: black, isort, prettier

3db2a76

[FIX] account_financial_report: Fix tests

899798f

On multi-company settings, we need to make sure we are searching and creating objects with the correct company associated. Also take into account previously created account groups TT28423

[FIX] account_financial_report: Refactor tests

0387e6d

Use core account test base, helping to ensure we have the correct accounting environment setup. If any of the localization modules are loaded, this will make this tests be skipped, instead of simply failing TT28423

Added translation using Weblate (Spanish (Mexico))

82e7b64

alexis-via and others added 22 commits November 24, 2025 08:39

[FIX] Account filter on general ledger wizard

c831e64

This commit both improves perfs by doing a single search() instead of search() + filtered and also make account selection by interval really work.

[FIX] account_financial_report: Fix log warning GeneralLedger Report

579f97b

Fixed warning seen in logs while generating General Ledger Report due to unsupported operand type.

[FIX] account_financial_report: General ledger report print issue whe…

c875518

…n there are multiple analytic accounts on single analytic distribution line.

[FIX][18.0] account_financial_report: fix scss affect other places

4b34256

Partial revert of 01f22b8 Adding css in web.assets_backend Affects the display of the Odoo interface Reverts to how it was in v17

[FIX] account_financial_report: fix for "group_id" is not searchable

4eea630

It happens because on 18.0 the group_id is not stored so the one2many account_ids is not working

[FIX] account_financial_report: correctly sum amount_currency in read…

387b9d6

…_group for trial balance On Odoo18 if you group:sum by amount_currency, if you don't put currency_id in the group field the amount_currency is removed by read_group function on account addon

[IMP] account_financial_report: Open items groupy by salesman

c382517

TT49193

[IMP] account_financial_report: Allow user cut label string of accoun…

71401c8

…t move line in reports Co-Authored-By: Pedro M. Baeza <[email protected]>

[FIX] account_financial_report: default set with sudo

937c6e5

If not, most users will have an access error.

[IMP] account_financial_report: pre-commit auto fixes

be16a07

micheledic force-pushed the 19.0_mig_account_financial_report branch from 028a608 to 49044aa Compare November 24, 2025 07:39

[MIG] account_financial_report: Migration to 19.0

5ea062c

micheledic force-pushed the 19.0_mig_account_financial_report branch from 49044aa to 5ea062c Compare November 24, 2025 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[19.0][MIG] account_financial_report: Migration to 19.0 #1413

[19.0][MIG] account_financial_report: Migration to 19.0 #1413

Uh oh!

micheledic commented Nov 18, 2025

Uh oh!

micheledic commented Nov 18, 2025

Uh oh!

micheledic commented Nov 19, 2025

Uh oh!

pedrobaeza commented Nov 19, 2025

Uh oh!

adnankkapasi commented Nov 21, 2025

Uh oh!

micheledic commented Nov 21, 2025

Uh oh!

micheledic commented Nov 24, 2025 •

edited

Loading

Uh oh!

pedrobaeza commented Dec 10, 2025

Uh oh!

micheledic commented Dec 10, 2025

Uh oh!

micheledic commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

[19.0][MIG] account_financial_report: Migration to 19.0 #1413

Are you sure you want to change the base?

[19.0][MIG] account_financial_report: Migration to 19.0 #1413

Uh oh!

Conversation

micheledic commented Nov 18, 2025

Uh oh!

micheledic commented Nov 18, 2025

Uh oh!

micheledic commented Nov 19, 2025

Uh oh!

pedrobaeza commented Nov 19, 2025

Uh oh!

adnankkapasi commented Nov 21, 2025

Uh oh!

micheledic commented Nov 21, 2025

Uh oh!

micheledic commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Dec 10, 2025

Uh oh!

micheledic commented Dec 10, 2025

Uh oh!

micheledic commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

micheledic commented Nov 24, 2025 •

edited

Loading