[18.0][FIX] report_xlsx

[alvaroGC-S73]

PR to Revert: #1057

Error to solve:

RPC_ERROR

Odoo Server Error

Traceback (most recent call last):
File "/opt/odoo/src/oca/reporting-engine/report_xlsx/controllers/main.py", line 65, in report_download
response = self.report_routes(

..........

File "/opt/odoo/src/oca/account-financial-reporting/account_financial_report/report/abstract_report.py", line 167, in _get_report_values
wizard = self.env[data["wizard_name"]].browse(data["wizard_id"])
KeyError: 'wizard_name'

The core issue is that the new JavaScript code introduced a bug: while attempting to fix context propagation for XLSX reports, it broke the standard method for passing wizard data (wizard_name, wizard_id). The old JS correctly serialized the essential action.data into the URL as an option query parameter, which the OCA backend modules rely on to find the wizard instance and generate the report.

[micheledic]

LGTM.
This bug blocks this PR OCA/account-financial-reporting#1413

[pedrobaeza]

But reverting this will undo the feature. This should instead fix the root cause, isn't it?

[micheledic]

But reverting this will undo the feature. This should instead fix the root cause, isn't it?

I tried this PR and the xls report works , imho can be merged to fix the issue

[pedrobaeza]

Yeah, but the reason why it was put initially will come to not be resolved, so that's why I say that this should fix the problem without losing the feature.

[micheledic]

@alvaroGC-S73 i just checked and it may be enough to remove those line and the xlsx report works
https://github.com/OCA/reporting-engine/blob/18.0/report_xlsx/static/src/js/report/action_manager_report.esm.js#L16-18
https://github.com/OCA/reporting-engine/blob/18.0/report_xlsx/static/src/js/report/action_manager_report.esm.js#L25-27

Or we have to push a PR to odoo core because the issue is caused on this line:
https://github.com/odoo/odoo/blob/70404624d7ea6f971182cbe4f4fe8fc064d2afd8/addons/web/controllers/report.py#L118

Of docids is passed, the date is not passed correctly

[JordiBForgeFlow]

In my opinion this PR should be merged ASAP because it fixes a breaking error. The feature that was introduced in d931ea7 was not fixing an error

[JordiBForgeFlow]

@alvaroGC-S73 i just checked and it may be enough to remove those line and the xlsx report works https://github.com/OCA/reporting-engine/blob/18.0/report_xlsx/static/src/js/report/action_manager_report.esm.js#L16-18 https://github.com/OCA/reporting-engine/blob/18.0/report_xlsx/static/src/js/report/action_manager_report.esm.js#L25-27

Or we have to push a PR to odoo core because the issue is caused on this line: https://github.com/odoo/odoo/blob/70404624d7ea6f971182cbe4f4fe8fc064d2afd8/addons/web/controllers/report.py#L118

Of docids is passed, the date is not passed correctly

I agree that the fix proposed here works, at least when we try to export the financial reports. But not sure if it breaks something else.

[pedrobaeza]

OK, let's revert it and let @DucTruongKomit to propose an alternative solution to his problem.

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1095-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at a602ffd. Thanks a lot for contributing to OCA. ❤️

[micheledic]

I created fwport #1099 @pedrobaeza