Skip to content

Conversation

@remi-filament
Copy link
Contributor

Take over #542 which was unattended and closed by lack of activity.

alexis-via and others added 10 commits September 22, 2025 10:25
Rename wizard obj to fr.siret.lookup
Test on stdnum version number
Currently translated at 97.7% (43 of 44 strings)

Translation: l10n-france-14.0/l10n-france-14.0-l10n_fr_siret_lookup
Translate-URL: https://translation.odoo-community.org/projects/l10n-france-14-0/l10n-france-14-0-l10n_fr_siret_lookup/fr/
'codedepartementetablissement' is not always set (in particular for companies in Corsica), so we now only use codepostaletablissement
Odoo 16 depends on both requests and python-stdnum, so there's no need to specify those dependencies.

Besides, [python-stdnum is pinned to 1.16][1]. Thus, when applying OCA/oca-ci#66 locally, the constraint failed. OCA addons should work with the dependencies pinned upstream.

[1]: https://github.com/odoo/odoo/blob/fe4d8e8014e50d4335e0a8b052b5098f3a79bcec/requirements.txt#L48

@moduon MT-4520
@remi-filament
Copy link
Contributor Author

remi-filament commented Sep 22, 2025

Hi @alexis-via would you mind having a look at this one ?
I am also wondering if we should not change a bit the behaviour about VIES validation, since it is very often ending with "VIES query failed: MS_MAX_CONCURRENT_REQ" as reported in #591

When using the wizard, if VIES check fails, you cannot import the line, you get a UserError and you are blocked there. We should allow of importing at least all other fields but vat.
On VIES website, they propose to move to async request : https://viesapi.eu/vies-error-the-maximum-number-of-concurrent-requests-has-been-reached-fr/

I am not sure it makes sense here, but maybe we could add 2 configuration parameters allowing :

  1. Enable / Disable check of VIES
  2. In case VIES check is disabled or timesout : take vat computed from SIREN (you will probably end up with a few incorrect VAT numbers) or do not compute vat (as done today)

For the timeout case we could probably raise a warning or notifification that this was not checked (or add a warning icon next to VAT ?) and maybe a button to recompute / check VAT number against VIES OR a cron job that would recompute all the ones marked with the warning icon (to get an async behaviour as suggested by VIES website) ?

What do you think ?

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants