MDACA 3.0.1 #2378
MDACA 3.0.1 #2378
Conversation
Bump to version 2.15.0 Updated Milestones for Atlas and WebAPI
* Implemented permission lookup to bypass hibernate. * Moved PermissionsDTO to PermissionManager * Removed GSON to use the app-wide ObjectMapper from Jackson * Removed unused imports to GSON.
* Create new webapi-databricks profile * Check for spark and databricks connection string info
…nto mdaca-3.0.1
…actoring due to deprecation
…tanalysis post and other endpoints.
…in aggregate analysis
… for only run when specific folder/files are updated as well updated 4th octet from .2 to .3
|
I'd like to consider bumping this up to JDK 21. From what I've read, there's improved light-weight threads for heavily threaded applications (as our webservices are very multi-threaded, this seems like it would benefit us), memory usage, the record structures, etc. I'm not requesting anything from you guys about this PR being pushed to JDK 21, but I was considering using this as a basis to bump it to JDK 21. Did you guys do any research on 19 vs. 21 where you identified potential challenges? |
| @@ -64,6 +64,11 @@ spring.jpa.properties.hibernate.dialect=${hibernate.dialect} | |||
| spring.jpa.properties.hibernate.generate_statistics=${spring.jpa.properties.hibernate.generate_statistics} | |||
| spring.jpa.properties.hibernate.jdbc.batch_size=${spring.jpa.properties.hibernate.jdbc.batch_size} | |||
| spring.jpa.properties.hibernate.order_inserts=${spring.jpa.properties.hibernate.order_inserts} | |||
| # Hibernate configuration | |||
| spring.jpa.hibernate.ddl-auto=validate | |||
There was a problem hiding this comment.
I don't think we should haev this here. We use Flyway to manage db migrations, and it's unclear how hibernate DDL validation will interact with this. I don't htink we should enable it.
|
@mdaca : I'm trying to start to build and run this branch locally, and Maven is having issues resolving a few dependencies: It seems there are a few MDACA-specific jars related to odysseusinc. Can you provide information as to how to resolve these dependencies? Are they published to a private nexus repository? |
| Flyway fw = Flyway.configure().dataSource(secondaryDataSource()) | ||
| .locations("classpath:db/migration/postgresql") | ||
| .placeholders(Map.of("ohdsiSchema", "webapi")).load(); | ||
| return fw; |
There was a problem hiding this comment.
Hello @mdaca :
I don't believe this is correct. These configurations are based on application properties, In addition, the newer versions of Flyway change the default name of the schema_version table, so existing applications will need a way to set the tablename (and schema).
|
I'm going to pull this into our OHDSI branch so that I'm able to push some commits to address some issutes. |
Requested by Anthony Sena for upgrade to Spring Boot 3 and JDK 17.