Merged
Conversation
CID 1667318: (#1 of 1): Structurally dead code (UNREACHABLE) unreachable: This code cannot be reached: hwloc_obj_t non_io_ancestor....
CID 1638288: (#1 of 1): Missing unlock (LOCK) 4. missing_unlock: Returning without unlocking xsk_protect.queue_protect.
For qa-simulation scenarios, especially for testing purposes. Task OISF#7885
For files edited during Task OISF#7885
Check for the existence of a flow before calling FlowGetStorageById() on it. Ticket: OISF#8308.
Check protocol before doing more expensive work.
Ticket: 8310
Ticket: 8310
Ticket: 8310
Ticket: 8310 And increases expressivity on the way by supporting other modes than equality
The Deprecation note on Syslog was partly conveying the opposite message, and we were missing a deprecation notice on the Syslog output section.
victorjulien
requested review from
a team,
jasonish and
jufajardini
as code owners
|
NOTE: This PR may contain new authors. |
|
Information: QA ran without warnings. Pipeline = 29778 |
jufajardini
approved these changes
Feb 20, 2026
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
All CI checks pass; consistent with original, approved PRs.
This was referenced Feb 20, 2026
Closed
This was referenced Feb 20, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#2926