Skip to content

src: rework includes wip#7658

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:include-less-v7
Closed

src: rework includes wip#7658
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:include-less-v7

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
None

Describe changes:

  • Remove unused includes in alert-debug log.c

Now that #7644 is merged, we can remove includes from C files independently from one another.

This is a draft that compiles on a single configuration, to see if it passes CI
Then I guess wee can try to automate the process

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #7658 (8e396c8) into master (5f4bcfe) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7658      +/-   ##
==========================================
- Coverage   75.93%   75.89%   -0.04%     
==========================================
  Files         659      661       +2     
  Lines      185639   186229     +590     
==========================================
+ Hits       140958   141344     +386     
- Misses      44681    44885     +204     
Flag Coverage Δ
fuzzcorpus 60.65% <ø> (-0.07%) ⬇️
suricata-verify 52.66% <ø> (+0.11%) ⬆️
unittests 60.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8388

@victorjulien
Copy link
Member

This is going to be good...

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on ips_afp_drop_chk.

Pipeline 8391

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on ips_afp_drop_chk.

Pipeline 8409

@catenacyber catenacyber force-pushed the include-less-v7 branch 3 times, most recently from ac0b504 to 353e460 Compare July 31, 2022 20:48
@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8429

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8431

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8432

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8433

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8434

@catenacyber catenacyber force-pushed the include-less-v7 branch 7 times, most recently from 7441e60 to 151efea Compare August 1, 2022 13:24
@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8438

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8439

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8440

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8441

@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8443

@catenacyber catenacyber force-pushed the include-less-v7 branch 2 times, most recently from 4544889 to 72321b6 Compare August 1, 2022 20:53
@suricata-qa
Copy link

WARNING:

field test baseline %
build_asan

Pipeline 8446

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_asan.

Pipeline 8452

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_asan.

Pipeline 8453

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 8454

@catenacyber catenacyber mentioned this pull request Aug 2, 2022
@catenacyber
Copy link
Contributor Author

Replaced by #7677

@catenacyber catenacyber closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants