Closed
Conversation
catenacyber
force-pushed
the
include-less-v8
branch
from
f3f2d0c to
cbe6d65
Compare
Member
|
nfqueue fails to build. Even though we have CI builds with the nfqueue depedencies, it does not get enabled by default. I added a commit to enable nfqueue for the Fedora 36 build over here: https://github.com/jasonish/suricata/runs/7637121133?check_suite_focus=true |
Contributor
Author
|
Thanks Jason, pushing a new version to test it |
catenacyber
force-pushed
the
include-less-v8
branch
from
cbe6d65 to
fafcaa1
Compare
Codecov Report
@@ Coverage Diff @@
## master #7677 +/- ##
==========================================
- Coverage 75.93% 75.91% -0.02%
==========================================
Files 659 661 +2
Lines 185639 186231 +592
==========================================
+ Hits 140958 141371 +413
- Misses 44681 44860 +179
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
ERROR: ERROR: QA failed on ips_afp_drop_chk. Pipeline 8466 |
ls src/*.c | while read i; do echo $i; python3 scripts/mininc.py $i; done
catenacyber
force-pushed
the
include-less-v8
branch
from
9843112 to
d36b7cd
Compare
Closed
Contributor
Author
|
Replaced by #7686 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
Now that #7644 is merged, we can remove includes from C files independently from one another.
Follows #7658 by being ready for review
Obtained with
./configure --enable-unittests --enable-debug --enable-geoip --enable-profiling --enable-luaThen
ls src/*.c | while read i; do echo $i; python3 scripts/mininc.py $i; doneThere is still some more removals :
memrchrAre there more config options to test ?