Add video #334
Open
Add video #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Learn Build status updates of commit 798e91f:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/presentation/how-to-add-a-video-to-a-slide-in-a-presentation.md | Details | ||
| samples/presentation/add_video/cs/add_video_cs.csproj | ✅Succeeded | ||
| samples/presentation/add_video/cs/Program.cs | ✅Succeeded | ||
| samples/presentation/add_video/vb/add_video_vb.vbproj | ✅Succeeded | ||
| samples/presentation/add_video/vb/Program.vb | ✅Succeeded | ||
| samples/presentation/insert_a_new_slideto/cs/insert_a_new_slideto_cs.csproj | ✅Succeeded | ||
| samples/samples.sln | ✅Succeeded |
docs/presentation/how-to-add-a-video-to-a-slide-in-a-presentation.md
- Line 105, Column 185: [Warning: disallowed-html-tag - See documentation]
HTML tag 'cNvPr' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder. - Line 105, Column 348: [Warning: disallowed-html-tag - See documentation]
HTML tag 'videoFile' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder. - Line 105, Column 427: [Warning: disallowed-html-tag - See documentation]
HTML tag 'hlinkClick' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder. - Line 105, Column 641: [Warning: disallowed-html-tag - See documentation]
HTML tag 'cNvPicPr' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
|
Learn Build status updates of commit 86255f9: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit c421671: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit df45c27: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit ed67d1c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 62a8d4c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
twsouthwick
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request adds functionality to programmatically insert a video into a slide of a presentation and updates the corresponding documentation to guide users through the process.
- Implements AddVideo method with Open XML SDK to manage video insertion, placeholder image, and related relationships.
- Updates documentation to include code snippets and a comprehensive guide for using the new video functionality.
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| samples/presentation/add_video/cs/Program.cs | Implements video insertion functionality using the Open XML SDK. |
| docs/presentation/how-to-add-a-video-to-a-slide-in-a-presentation.md | Updates documentation with detailed usage steps and code references. |
Files not reviewed (4)
- samples/presentation/add_video/cs/add_video_cs.csproj: Language not supported
- samples/presentation/add_video/vb/Program.vb: Language not supported
- samples/presentation/add_video/vb/add_video_vb.vbproj: Language not supported
- samples/samples.sln: Language not supported
|
Looks like copilot found some spelling issues, but other than that, LGTM |
twsouthwick
reviewed
Mar 31, 2025
twsouthwick
reviewed
Mar 31, 2025
| } | ||
| // <Snippet2> | ||
| //Get presentation part | ||
| PresentationPart presentationPart = presentationDocument.PresentationPart; |
There was a problem hiding this comment.
Do the samples not use var? Not a blocker, but we should be consistent
There was a problem hiding this comment.
I will stick with data types but we may discuss it on the meeting as the current samples have it mixed var and data types. Thanks
twsouthwick
reviewed
Mar 31, 2025
twsouthwick
reviewed
Mar 31, 2025
|
|
||
| ## Getting a Presentation Object | ||
|
|
||
| In the Open XML SDK, the `PresentationDocument` class represents a |
There was a problem hiding this comment.
I think there's a shared snippet that could be used here that has links to the APIs. @mikeebowen do you know what I'm referring to?
Open
twsouthwick
requested changes
Mar 31, 2025
Typo Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Taylor Southwick <[email protected]>
|
Learn Build status updates of commit 7978539: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Co-authored-by: Taylor Southwick <[email protected]>
|
Learn Build status updates of commit 83d351e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit b869034: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 8db9e3b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
twsouthwick
approved these changes
Apr 1, 2025
|
Learn Build status updates of commit 4283f96: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit b35f7d8: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another pull request @twsouthwick Thanks