-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust-Axum][Breaking Change] Implement a customizable error handler #20463
base: master
Are you sure you want to change the base?
[Rust-Axum][Breaking Change] Implement a customizable error handler #20463
Conversation
Can this get added to the 7.12.0 milestone? I'd love to use this. |
de95283
to
9841fa4
Compare
@Victoria-Casasampere-BeeTheData I have one concern here:
In this way, it would be the best if could include those info to ErrorHandler trait |
This is not something that I needed available on my use case, so did not consider it, but I can see how having that information can be useful. I will add some additional arguments with that information to the trait method. |
@linxGnu The error handler now has access to the Method, Host and CookieJar, every other parameter is way too endpoint specific, and errors that depend on knowing that data should be handled on the endpoint itself rather than the global error handler. For the purposes of error logging, this information is enough, as the additional data can be logged via instrumenting by the user, and can be looked back to when an error log pops up, as they would both share the same method, host and cookies. |
This PR implements a way to handle errors that are not handled in the API implementations with the creation of a new
ErrorHandler
trait. This is beneficial for dealing with unknown possible errors, as well as dealing with the repetitive code that comes from manually handling recurring errors between multiple different endpoints.The breaking changes are minimal and unlikely that they will affect people. These are:
Send + Sync + 'static
crate::apis::ErrorHandler
The default implementation sets the error type to
() / unit
, this makes users migrating to the newer version to only be required to add the lineimpl data_models::apis::ErrorHandler for ServerImpl {}
to complete the migration.The error handler itself defaults to logging the returned error with its Debug implementation on the error log level. Users that wish to use their own error type only need to change the Result::Err return type of the methods in the API traits implementations, as well as specify the same error type as the generic type of the
ErrorHandler
trait being implemented in the server implementation.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328 @linxGnu