Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Bump axum and axum-extra #20548

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

whirm
Copy link
Contributor

@whirm whirm commented Jan 28, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@frol, @farcaller, @richardwhiuk, @paladinzh, @jacob-pro ping!

@whirm whirm changed the title Bump axum and axum-extra [Rust] Bump axum and axum-extra Jan 29, 2025
@wing328
Copy link
Member

wing328 commented Jan 31, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Jan 31, 2025

cc @linxGnu for review

@whirm
Copy link
Contributor Author

whirm commented Feb 3, 2025

@wing328 Fixed. Thanks for the catch!

@linxGnu
Copy link
Contributor

linxGnu commented Feb 3, 2025

@whirm
Thank you for making the PR.

Basically, LGTM, the same as I did last month (my local branch): master...linxGnu:openapi-generator:rust_axum_authorization

However, please wait for #20463 to merge first. It contains necessary changes.

@wing328
Copy link
Member

wing328 commented Feb 9, 2025

@whirm please resolve the merge conflicts when you've time.

 - This bump requires fixing path parameters due to matchit transitive dependency
changes (See tokio-rs/axum#2645).

 - The `Host` extractor has been moved from `axum` to `axum-extra`.
 - Axum now ships multipart extractor support, switch to that.
@whirm
Copy link
Contributor Author

whirm commented Feb 10, 2025

@whirm please resolve the merge conflicts when you've time.

Done!

@wing328 wing328 merged commit 21bf477 into OpenAPITools:master Feb 10, 2025
19 of 20 checks passed
@whirm whirm deleted the rust/bump_axum branch February 10, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants