Use replacements in compact-contracts, update copy #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Nice work on the improvements @emnul! I left a few comments
Comment on lines
+96
to
102
| ### Witnesses [toc] [#AccessControl-Witnesses] | ||
| ### Witnesses [!toc] [#AccessControl-Witnesses] | ||
| None. | ||
| ### Circuits [toc] [#AccessControl-Circuits] | ||
| ### Circuits [!toc] [#AccessControl-Circuits] |
There was a problem hiding this comment.
I omitted the Ledger, Witnesses, and Circuits grouping names from the ToC because this breaks the semantic hierarchy
<h2>Core</h2>
<h3>AccessControl</h3>
<h3>Ledger</h3> // Is within AccessControl but is displayed as adjacent
<h4>fooSig</h4>We can remove core and promote AccessControl as an h2 header like in the Ownable API so the hierarchy would be:
<h2>AccessControl</h2>
<h3>Ledger</h3>
<h4>fooSig</h4>There was a problem hiding this comment.
If we like this approach, the same applies to the other modules with a Core header
There was a problem hiding this comment.
I think it'd be even better if we had a dropdown for these groupings in the ToC. Outside the scope of this PR though
Add newline Co-authored-by: Andrew Fleming <[email protected]>
…/docs into update-compact-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.