-
Notifications
You must be signed in to change notification settings - Fork 6
Use replacements in compact-contracts, update copy #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
f2ac355
Add replacements for compact contracts
emnul 002523e
Use newly defined replacement syntax
emnul fd9f9e9
Reorg Access pages
emnul 75d8871
Fix malformed link
emnul 8f56682
Add Access Control intro block
emnul 73ac864
Add link
emnul 2f14f1c
Update imports
emnul 958964e
Update import
emnul aa82fe3
Add additional links, fix formatting
emnul c5c189b
Rename document, fix import paths, broken link
emnul f02d50b
update import paths
emnul ce7a1c0
Update import paths, links
emnul 25230f3
Update import paths, url path
emnul 7c3f6a6
Update import paths
emnul ef6e220
update import paths
emnul 3fbd4d2
Merge branch 'main' into update-compact-docs
emnul e5a3179
Fix formatting
emnul e825011
update imports
emnul aaa7c0c
Update import
emnul 4cd7b1a
Update page names
emnul 14f1c96
Update Page name
emnul 9bb537f
Rename files and update paths
emnul 0f9974f
Fix toc formatting
emnul 71e9f43
Update import path
emnul c9f73ad
Fix toc formatting
emnul b99decd
update import
emnul 9f79196
Fix toc formatting
emnul f99d585
Update import path
emnul 2509c7e
Fix toc formatting
emnul e6556ed
Update import path
emnul e944eef
Fix toc formatting
emnul cbbc000
Fix import path
emnul f578f25
Fix toc formatting
emnul 01ff0c6
Fix toc formating
emnul 6a80c79
Update section org
emnul c127f83
Update section org
emnul e94f6ed
format:fix
emnul 7093431
Update links
emnul 80e7475
Update broken link
emnul 1156988
Update content/contracts-compact/utils/constants.js
emnul 7cf6bda
Merge branch 'main' into update-compact-docs
emnul e0943e5
Merge branch 'update-compact-docs' of https://github.com/OpenZeppelin…
emnul 1e1fb12
Remove Core H2
emnul 44341c6
Update module formating to use GitHubLinkHeader
emnul 9ef2461
Fix invalid DOM property error
emnul 5de8da3
format:fix
emnul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I omitted the
Ledger
,Witnesses
, andCircuits
grouping names from the ToC because this breaks the semantic hierarchyWe can remove
core
and promoteAccessControl
as an h2 header like in the Ownable API so the hierarchy would be:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we like this approach, the same applies to the other modules with a
Core
headerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be even better if we had a dropdown for these groupings in the ToC. Outside the scope of this PR though