-
Notifications
You must be signed in to change notification settings - Fork 189
i18n(fr): Improve translation quality #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,29 +4,29 @@ | |
| "direction": "ltr", | ||
| "strings": { | ||
| "placeholder": "Rechercher", | ||
| "clear_search": "Nettoyer", | ||
| "load_more": "Charger plus de résultats", | ||
| "clear_search": "Effacer", | ||
| "load_more": "Afficher plus de résultats", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Charger" "load" implies a technical action, but from the user perspective, results are being shown. "Afficher" (display) is more accurate and user-friendly for french speakers. |
||
| "search_label": "Recherche sur ce site", | ||
| "filters_label": "Filtres", | ||
| "zero_results": "Pas de résultat pour [SEARCH_TERM]", | ||
| "zero_results": "Aucun résultat pour [SEARCH_TERM]", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Pas de résultat" is correct but informal. "Aucun résultat" is the standard phrasing used in French UI and feels more polished. |
||
| "many_results": "[COUNT] résultats pour [SEARCH_TERM]", | ||
| "one_result": "[COUNT] résultat pour [SEARCH_TERM]", | ||
| "total_zero_results": "Pas de résultat", | ||
| "total_one_result": "[COUNT] résultat", | ||
| "one_result": "Un résultat pour [SEARCH_TERM]", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this string is used when there is exactly one result, using "Un" instead of [COUNT] is more natural and consistent with "zero_results" which also uses explicit wording instead of a variable. The similar reasoning that was applied in the German translation by @randomguy-2650 in #1096 : a screen reader may also read "[COUNT] résultat" with incorrect phrasing. |
||
| "total_zero_results": "Aucun résultat", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment on line R13. |
||
| "total_one_result": "Un résultat", | ||
|
Comment on lines
+14
to
+15
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment on line R13. |
||
| "total_many_results": "[COUNT] résultats", | ||
| "alt_search": "Pas de résultat pour [SEARCH_TERM]. Montre les résultats pour [DIFFERENT_TERM] à la place", | ||
| "search_suggestion": "Pas de résultat pour [SEARCH_TERM]. Essayer une des recherches suivantes:", | ||
| "searching": "Recherche [SEARCH_TERM]...", | ||
| "alt_search": "Aucun résultat pour [SEARCH_TERM]. Afficher les résultats pour [DIFFERENT_TERM] à la place", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Montre" is correct but an informal imperative that directly addresses the user, it could feel out of place this context. The infinitive "Afficher" is more appropriate here, as using the infinitive over the imperative is recommended for impersonal instructions, indications, similar to how instructions in documentation or recipes are written in French. |
||
| "search_suggestion": "Aucun résultat pour [SEARCH_TERM]. Essayez l'une des recherches suivantes :", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Essayer" (infinitive) is inconsistent with the direct address used elsewhere. "Essayez" (formal imperative) is more appropriate as it directly and politely addresses the user. Adding the elision article "l'" is also more grammatically correct than "une des" alone, in this context. |
||
| "searching": "Recherche de [SEARCH_TERM] en cours...", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Recherche [SEARCH_TERM]" is ambiguous and could be read as a noun ("Search : [SEARCH_TERM]") or an informal imperative. "Recherche de [SEARCH_TERM] en cours" makes the ongoing action explicit and is more informative for the user. |
||
| "results_label": "Résultats de recherche", | ||
| "keyboard_navigate": "naviguer", | ||
| "keyboard_select": "choisir", | ||
| "keyboard_select": "sélectionner", | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Choisir" (to choose) is less precise in UI context. "Sélectionner" is the standard French term used in interfaces and is consistent with the overall vocabulary of the file. Note: The infinitive is intentionally kept here, as these keyboard shortcut labels are impersonal indicators, not direct instructions addressed to the user. |
||
| "keyboard_clear": "effacer", | ||
| "keyboard_close": "fermer", | ||
| "keyboard_search": "rechercher", | ||
| "error_search": "Échec de la recherche", | ||
| "filter_selected_one": "[COUNT] sélectionné", | ||
| "filter_selected_many": "[COUNT] sélectionnés", | ||
| "input_hint": "Les résultats apparaîtront au fur et à mesure de la saisie", | ||
| "loading": "Chargement" | ||
| "loading": "Chargement en cours..." | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Chargement" alone feels rough. "Chargement en cours..." makes the ongoing action explicit and keeps the consistency with "Recherche de [SEARCH_TERM] en cours..." used in the "searching" string. |
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Nettoyer" is indeed the literal translation for "clear" but feels unnatural in this UI context.
"Effacer" is the standard French term used in search inputs.