Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when allocating some nodes with weapon set passives #7

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

justjuangui
Copy link
Contributor

@justjuangui justjuangui commented Jan 18, 2025

mod type condition can have varList instead of var, this pr validate
if we have var and the check if this condition if about weaponSet
closes PathOfBuildingCommunity/PathOfBuilding-PoE2#317

mod type condition can have varList instead of var, this pr validate
if we have var and the check if this condition if about weaponSet
closes PathOfBuildingCommunity/PathOfBuilding-PoE2#317
@justjuangui justjuangui changed the title Fixes #317 Fix nil mod type check Condition Weaponset Jan 18, 2025
@LocalIdentity LocalIdentity changed the title Fix nil mod type check Condition Weaponset Fix crash when allocating some nodes with weapon set passives Jan 18, 2025
@justjuangui justjuangui changed the title Fix crash when allocating some nodes with weapon set passives Fix crash when allocation some nodes with weapon set passives Jan 18, 2025
@LocalIdentity LocalIdentity added the crash Causes PoB to crash and is High Priority label Jan 18, 2025
@LocalIdentity LocalIdentity merged commit 4520ac8 into PathOfBuildingCommunity:dev Jan 18, 2025
1 of 2 checks passed
@justjuangui justjuangui added the bug Something isn't working label Jan 18, 2025
@LocalIdentity LocalIdentity changed the title Fix crash when allocation some nodes with weapon set passives Fix crash when allocating some nodes with weapon set passives Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Causes PoB to crash and is High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lua:160: attempt to index field 'var' (a nil value)
2 participants