Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Exploit Weakness" Support not applying for "ArmourFullyBroken" #801

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

majochem
Copy link
Contributor

@majochem majochem commented Feb 17, 2025

Fixes #731 .

Description of the problem being solved:

  • Original PR forgot to change "ArmourBroken" to "ArmourFullyBroken" in the statMap for "Exploit Weakness" support in sup_str.txt . Now it's fixed and works again.

Steps taken to verify a working solution:

  • Check Config for "Is enemy Armour broken?" is set correctly (no manual value)
  • Exploit Weakness support damage bonus applies correctly

After screenshot:

image

note: the 51.7% is a result of rounding due to the tiny damage values. modifier is correctly applied as "50% More"

@majochem majochem marked this pull request as ready for review February 17, 2025 09:17
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Mar 10, 2025
@LocalIdentity LocalIdentity merged commit 87e7e0b into PathOfBuildingCommunity:dev Mar 10, 2025
2 checks passed
@Blitz54 Blitz54 mentioned this pull request Mar 19, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants