Build/ci cd 분리 #3
Conversation
There was a problem hiding this comment.
Pull request overview
This PR separates CI and CD workflows and removes the dependency on external JWT key files during testing by generating test keys in-memory.
- Introduced a test-specific application profile with H2 database configuration
- Created a
TestKeysutility class to generate RSA key pairs for testing - Split the combined CI/CD workflow into separate CI (pull request) and CD (master branch push) workflows
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/resources/application-test.yml | Adds test profile configuration with H2 database and JWT key paths |
| src/test/java/me/gg/pinit/utils/TestKeys.java | New utility class to generate RSA key pairs for testing without external files |
| src/test/java/me/gg/pinit/PinitAuthApplicationTests.java | Configures test JwtTokenProvider bean using generated test keys |
| .github/workflows/ci.yml | New CI workflow triggered on pull requests for build and test |
| .github/workflows/cd.yml | Updated CD workflow (renamed from CI/CD) with cleaned up comments |
Comments suppressed due to low confidence (1)
.github/workflows/cd.yml:58
- Kubernetes v1.33.6 may not exist yet. As of early 2025, the latest stable Kubernetes versions are in the v1.31-v1.32 range. Please verify that v1.33.6 is a valid and available version, or adjust to a confirmed stable version like v1.31.x or v1.32.x to avoid installation failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Bean | ||
| @Primary | ||
| JwtTokenProvider testJwtTokenProvider() { | ||
| return new JwtTokenProvider(TestKeys.privateKey(), TestKeys.publicKey(), "https://pinit.go-gradually.me", Duration.ofMinutes(5), Duration.ofDays(14)); |
There was a problem hiding this comment.
The hardcoded issuer URL "https://pinit.go-gradually.me" duplicates the value from the production SecurityConfig. Consider extracting this to a configuration property or constant to maintain consistency and make it easier to update across the codebase.
| cache: gradle | ||
|
|
||
| - name: Build & Test | ||
| run: ./gradlew clean test build |
There was a problem hiding this comment.
The command runs tests twice: once explicitly with 'test' and again as part of 'build' (since build depends on test in Gradle). Consider using either './gradlew clean build' (which includes test) or './gradlew clean test' if you only want to run tests without creating the final JAR. The current approach wastes CI resources and time.
| run: ./gradlew clean test build | |
| run: ./gradlew clean build |
변경된 점