Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- 코드 리뷰 코멘트는 항상 한국어로 작성한다.
- 변경사항별로: (1) 문제점 (2) 영향 (3) 수정 제안 순서로 작성한다.
- 보안/성능/동시성 이슈를 우선 점검한다.
9 changes: 4 additions & 5 deletions .github/workflows/cicd.yaml → .github/workflows/cd.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: pinit-auth CI/CD
name: pinit-auth CD

on:
push:
Expand All @@ -10,7 +10,7 @@ permissions:

jobs:
build-test-push-deploy:
runs-on: [ arc-runner-set ] # ARC 러너 라벨에 맞게 조정
runs-on: [ arc-runner-set ]

env:
IMAGE_REPO: ghcr.io/pinit-scheduler/pinit-auth/app
Expand All @@ -27,7 +27,7 @@ jobs:
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: "21" # 사용 버전에 맞게 조정
java-version: "21"
cache: gradle

- name: Build & Test
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Install kubectl (if needed)
uses: azure/setup-kubectl@v4
with:
version: v1.33.6 # 클러스터 버전에 맞게 조정
version: v1.33.6

- name: Create kubeconfig from in-cluster ServiceAccount
shell: bash
Expand Down Expand Up @@ -89,7 +89,6 @@ jobs:
- name: Deploy (apply manifest with GITHUB_SHA substitution)
shell: bash
run: |
# envsubst가 없으면 설치 필요(러너 이미지에 포함시키는 방식을 권장)
command -v envsubst >/dev/null 2>&1 || (echo "envsubst not found" && exit 1)

export GITHUB_SHA="${{ github.sha }}"
Expand Down
25 changes: 25 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: pinit-auth CI

on:
pull_request:

permissions:
contents: read

jobs:
build-test:
runs-on: [ arc-runner-set ]

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup JDK
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: "21"
cache: gradle

- name: Build & Test
run: ./gradlew clean test build
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command runs tests twice: once explicitly with 'test' and again as part of 'build' (since build depends on test in Gradle). Consider using either './gradlew clean build' (which includes test) or './gradlew clean test' if you only want to run tests without creating the final JAR. The current approach wastes CI resources and time.

Suggested change
run: ./gradlew clean test build
run: ./gradlew clean build

Copilot uses AI. Check for mistakes.
9 changes: 8 additions & 1 deletion src/test/java/me/gg/pinit/PinitAuthApplicationTests.java
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
package me.gg.pinit;

import me.gg.pinit.infrastructure.jwt.JwtTokenProvider;
import org.junit.jupiter.api.Test;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.ActiveProfiles;
import org.springframework.test.context.bean.override.mockito.MockitoBean;

@ActiveProfiles("test")
@SpringBootTest
class PinitAuthApplicationTests {

@MockitoBean
JwtTokenProvider jwtTokenProvider;


@Test
void contextLoads() {
}

}