Skip to content

Make non-planarity warning show quantitative error for .from_values of FourierXY and FourierPlanar curves - #2283

Merged
YigitElma merged 3 commits into
masterfrom
dp/non-planar-warning
Aug 14, 2026
Merged

Make non-planarity warning show quantitative error for .from_values of FourierXY and FourierPlanar curves#2283
YigitElma merged 3 commits into
masterfrom
dp/non-planar-warning

Conversation

@dpanici

@dpanici dpanici commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Would be good to show the quantitative warning, as sometimes the non-planar error in the fit is miniscule. Would be good for user to know, if we are warning them anyways they should get this info.

@YigitElma YigitElma added the easy Short and simple to code or review label Aug 9, 2026
@dpanici dpanici added the skip_changelog No need to update changelog on this PR label Aug 10, 2026
@YigitElma
YigitElma requested a review from daniel-dudt August 13, 2026 16:25
@YigitElma
YigitElma requested review from a team, IssraAli, ddudt, f0uriest, lkadz, rahulgaur104, singh-jaydeep and unalmis and removed request for a team August 13, 2026 16:25
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Memory benchmark result

|               Test Name                |      %Δ      |    Master (MB)     |      PR (MB)       |    Δ (MB)    |    Time PR (s)     |  Time Master (s)   |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
  test_objective_jac_w7x                 |   -0.65 %    |     4.279e+03      |     4.251e+03      |    -27.80    |       31.55        |       29.26        |
  test_proximal_jac_w7x_with_eq_update   |    0.19 %    |     6.840e+03      |     6.854e+03      |    13.32     |       155.01       |       155.37       |
  test_proximal_freeb_jac                |    0.03 %    |     1.353e+04      |     1.354e+04      |     4.38     |       81.65        |       81.49        |
  test_proximal_freeb_jac_blocked        |   -0.07 %    |     7.885e+03      |     7.879e+03      |    -5.81     |       70.48        |       69.64        |
  test_proximal_freeb_jac_batched        |   -0.06 %    |     7.884e+03      |     7.880e+03      |    -4.59     |       69.65        |       69.75        |
  test_proximal_jac_ripple               |   -1.02 %    |     3.826e+03      |     3.787e+03      |    -39.04    |       56.08        |       54.77        |
  test_proximal_jac_ripple_bounce1d      |    0.27 %    |     3.972e+03      |     3.982e+03      |    10.73     |       68.36        |       68.51        |
  test_eq_solve                          |   -0.12 %    |     1.823e+03      |     1.821e+03      |    -2.28     |       52.78        |       52.53        |
  test_objective_quadratic_flux_jac      |    0.51 %    |     2.703e+03      |     2.716e+03      |    13.66     |       53.57        |       53.36        |

For the memory plots, go to the summary of Memory Benchmarks workflow and download the artifact.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.37%. Comparing base (ef795c5) to head (ab66367).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2283      +/-   ##
==========================================
+ Coverage   84.50%   94.37%   +9.87%     
==========================================
  Files         101      101              
  Lines       28953    28953              
==========================================
+ Hits        24466    27325    +2859     
+ Misses       4487     1628    -2859     
Files with missing lines Coverage Δ
desc/geometry/curve.py 96.44% <ø> (+16.86%) ⬆️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YigitElma
YigitElma merged commit 21b79ed into master Aug 14, 2026
27 checks passed
@YigitElma
YigitElma deleted the dp/non-planar-warning branch August 14, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy Short and simple to code or review skip_changelog No need to update changelog on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants