Make non-planarity warning show quantitative error for .from_values of FourierXY and FourierPlanar curves - #2283
Merged
Merged
Conversation
YigitElma
approved these changes
Aug 8, 2026
YigitElma
requested review from
a team,
IssraAli,
ddudt,
f0uriest,
lkadz,
rahulgaur104,
singh-jaydeep and
unalmis
and removed request for
a team
August 13, 2026 16:25
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | -0.65 % | 4.279e+03 | 4.251e+03 | -27.80 | 31.55 | 29.26 |
test_proximal_jac_w7x_with_eq_update | 0.19 % | 6.840e+03 | 6.854e+03 | 13.32 | 155.01 | 155.37 |
test_proximal_freeb_jac | 0.03 % | 1.353e+04 | 1.354e+04 | 4.38 | 81.65 | 81.49 |
test_proximal_freeb_jac_blocked | -0.07 % | 7.885e+03 | 7.879e+03 | -5.81 | 70.48 | 69.64 |
test_proximal_freeb_jac_batched | -0.06 % | 7.884e+03 | 7.880e+03 | -4.59 | 69.65 | 69.75 |
test_proximal_jac_ripple | -1.02 % | 3.826e+03 | 3.787e+03 | -39.04 | 56.08 | 54.77 |
test_proximal_jac_ripple_bounce1d | 0.27 % | 3.972e+03 | 3.982e+03 | 10.73 | 68.36 | 68.51 |
test_eq_solve | -0.12 % | 1.823e+03 | 1.821e+03 | -2.28 | 52.78 | 52.53 |
test_objective_quadratic_flux_jac | 0.51 % | 2.703e+03 | 2.716e+03 | 13.66 | 53.57 | 53.36 |For the memory plots, go to the summary of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2283 +/- ##
==========================================
+ Coverage 84.50% 94.37% +9.87%
==========================================
Files 101 101
Lines 28953 28953
==========================================
+ Hits 24466 27325 +2859
+ Misses 4487 1628 -2859
🚀 New features to boost your workflow:
|
ddudt
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be good to show the quantitative warning, as sometimes the non-planar error in the fit is miniscule. Would be good for user to know, if we are warning them anyways they should get this info.