Skip to content

Make non-planarity warning show quantitative error for .from_values of FourierXY and FourierPlanar curves #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YigitElma merged 3 commits into from
Aug 14, 2026
+6 −2
Merged

Make non-planarity warning show quantitative error for .from_values of FourierXY and FourierPlanar curves #2283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08933da
make non-planarity warning show quantitative error:
dpanici Aug 6, 2026
4cb146a
Merge branch 'master' into dp/non-planar-warning
YigitElma Aug 13, 2026
ab66367
Merge branch 'master' into dp/non-planar-warning
YigitElma Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions desc/geometry/curve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,9 @@ def from_values(cls, coords, N=10, basis="xyz", name=""):
warnif(
np.max(np.abs(coords_rotated[:, 2])) > 1e-14, # check Z=0 for all points
UserWarning,
"Curve values are not planar! Using the projection onto a plane.",
"Curve values are not planar! "
f"Max planarity violation of {np.max(np.abs(coords_rotated[:, 2])):1.2e} m."
" Using the projection onto a plane.",
)

# polar angle
Expand Down Expand Up @@ -1341,7 +1343,9 @@ def from_values(cls, coords, N=10, s=None, basis="xyz", name=""):
warnif(
np.max(np.abs(Z)) > 1e-14, # check that Z=0 for all points
UserWarning,
"Curve values are not planar! Using the projection onto a plane.",
"Curve values are not planar! "
f"Max planarity violation of {np.max(np.abs(Z)):1.2e} m."
" Using the projection onto a plane.",
)

if isinstance(s, str):
Expand Down
Loading