-
Notifications
You must be signed in to change notification settings - Fork 0
Add option to set custom corpus #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: upstream-clean
Are you sure you want to change the base?
Conversation
|
I think we cannot get rid of this implementation entirely. I simplified code a bit but the main idea remains:
I added a detail of the alternative that they've suggested us to do for the comparison. For any benchmark that we need to have a custom seed we need to repeatedly do the following (libpng for example):
I believe we'd better go with our implementation for the custom seed. I think the above alternative is doable but not really convenient. What do you think? @wuestholz |
|
@jiradeto Thanks a lot! Maybe we should try the following:
The key issue seems to be that each benchmark has their own structure and seeds directory. Modifying it would require changes to the Dockerfile and/or the build script. The combined PR should include 4 commits:
|
This PR allows users to set custom seed corpus for the experiment. To use this option, one has to set
--custom-seed-corpus-dirto path that has input files for the running benchmarks.For example:
and
/local/my-custom-corporamust have the following content: