Fix Small Linting errors - #124
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve build-blocking lint/typecheck issues by aligning path alias configuration and adjusting dialog usage in the header UI.
Changes:
- Updates TypeScript path alias configuration in
tsconfig.app.json. - Refactors
ButtonTraydialogs to removeonConfirmprops and handle confirmation via explicit buttons. - Adds a new shared
Dialogcomponent wrapping@radix-ui/react-dialog.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsconfig.app.json | Adjusts TS path alias mapping used during app compilation. |
| src/components/header/ButtonTray.tsx | Updates dialog invocations to match the new Dialog API (no onConfirm). |
| src/components/Dialog.tsx | Adds a reusable Radix-based dialog component with controlled/uncontrolled support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -23,9 +23,8 @@ | |||
| "noUncheckedSideEffectImports": true, | |||
|
|
|||
| /* Base URL */ | |||
There was a problem hiding this comment.
tsconfig.app.json defines compilerOptions.paths but no compilerOptions.baseUrl. TypeScript requires baseUrl to be set when using paths, and because tsconfig.app.json does not extends the root tsconfig.json, the baseUrl from tsconfig.json will not apply during tsc -b. Add "baseUrl": "." here (or add an extends to inherit the root settings) to avoid TS5090/failed builds.
| /* Base URL */ | |
| /* Base URL */ | |
| "baseUrl": ".", |
This PR fixes the remaining errors preventing a build.