Skip to content

Fix Small Linting errors - #124

Merged
ramonechen merged 3 commits into
main-previewfrom
fix-linting
Apr 14, 2026
Merged

Fix Small Linting errors#124
ramonechen merged 3 commits into
main-previewfrom
fix-linting

Conversation

@mirmirmirr

Copy link
Copy Markdown
Contributor

This PR fixes the remaining errors preventing a build.

@mirmirmirr
mirmirmirr requested a review from ramonechen April 14, 2026 20:31
@mirmirmirr
mirmirmirr marked this pull request as ready for review April 14, 2026 20:31
Copilot AI review requested due to automatic review settings April 14, 2026 20:31
@ramonechen
ramonechen merged commit 8995d1e into main-preview Apr 14, 2026
5 checks passed
@ramonechen
ramonechen deleted the fix-linting branch April 14, 2026 20:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to resolve build-blocking lint/typecheck issues by aligning path alias configuration and adjusting dialog usage in the header UI.

Changes:

  • Updates TypeScript path alias configuration in tsconfig.app.json.
  • Refactors ButtonTray dialogs to remove onConfirm props and handle confirmation via explicit buttons.
  • Adds a new shared Dialog component wrapping @radix-ui/react-dialog.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
tsconfig.app.json Adjusts TS path alias mapping used during app compilation.
src/components/header/ButtonTray.tsx Updates dialog invocations to match the new Dialog API (no onConfirm).
src/components/Dialog.tsx Adds a reusable Radix-based dialog component with controlled/uncontrolled support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tsconfig.app.json
@@ -23,9 +23,8 @@
"noUncheckedSideEffectImports": true,

/* Base URL */

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsconfig.app.json defines compilerOptions.paths but no compilerOptions.baseUrl. TypeScript requires baseUrl to be set when using paths, and because tsconfig.app.json does not extends the root tsconfig.json, the baseUrl from tsconfig.json will not apply during tsc -b. Add "baseUrl": "." here (or add an extends to inherit the root settings) to avoid TS5090/failed builds.

Suggested change
/* Base URL */
/* Base URL */
"baseUrl": ".",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants