Skip to content

Fix Small Linting errors #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonechen merged 3 commits into from
Apr 14, 2026
Merged

Fix Small Linting errors #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19abcc0
remove onConfirm from dialog props
mirmirmirr Apr 14, 2026
c7d8b29
rename dialog.tsx
mirmirmirr Apr 14, 2026
2484741
Update tsconfig.app.json
mirmirmirr Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 src/components/dialog.tsx → src/components/Dialog.tsx
View file
Open in desktop
File renamed without changes.
6 changes: 0 additions & 6 deletions src/components/header/ButtonTray.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ export default function ButtonTray() {
open={activeDialog === "reset"}
onOpenChange={(open) => !open && setActiveDialog(null)}
description="Are you sure you want to reset your entire workspace? This will delete all semesters and courses."
onConfirm={confirmReset}
>
<div className="flex gap-4 mt-6 justify-center">
<button
Expand All @@ -178,7 +177,6 @@ export default function ButtonTray() {
open={activeDialog === "import"}
onOpenChange={(open) => !open && setActiveDialog(null)}
description="Importing will overwrite your current plan. This action cannot be undone."
onConfirm={confirmImport}
>
<div className="flex gap-4 mt-6 justify-center">
<button
Expand All @@ -202,10 +200,6 @@ export default function ButtonTray() {
open={activeDialog === "error"}
onOpenChange={(open) => !open && setActiveDialog(null)}
description="There was an error importing your file. Please make sure it is a valid CARPI file and try again."
onConfirm={() => {
setActiveDialog(null);
return true;
}}
>
<div className="flex gap-4 mt-6 justify-center">
<button
Expand Down
3 changes: 1 addition & 2 deletions tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
"noUncheckedSideEffectImports": true,

/* Base URL */

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsconfig.app.json defines compilerOptions.paths but no compilerOptions.baseUrl. TypeScript requires baseUrl to be set when using paths, and because tsconfig.app.json does not extends the root tsconfig.json, the baseUrl from tsconfig.json will not apply during tsc -b. Add "baseUrl": "." here (or add an extends to inherit the root settings) to avoid TS5090/failed builds.

Suggested change
/* Base URL */
/* Base URL */
"baseUrl": ".",

Copilot uses AI. Check for mistakes.
"baseUrl": "./src",
"paths": {
"@/*": ["./*"]
"@/*": ["./src/*"]
}
},
"include": ["src"]
Expand Down
Loading