Added AI-generated label indicator and tooltip message #4094

ishajagadish · 2025-12-11T22:22:21Z

Resolves #4035

Added an “AI-generated” icon and tooltip across gallery, admin/label map, and validate views. The frontend uses new AiLabelIndicator helpers and CSS tweaks so the icon sits on the marker corner, and a tooltip explains the label was AI-generated. On the backend, LabelTable.getRecentLabelsMetadata flags ai_generated via a SQL EXISTS check on labels placed by users with the AI role, and that flag is exposed through LabelFormats/AdminController to drive the UI.

Before/After screenshots

Before:

After:

Testing instructions

Navigate to any of the following pages: /validate, /expertValidate, /mobileValidate, /gallery, /labelMap, /admin (the "Map" tab), /admin (the "Labels" tab), /admin (the "Label Search" tab), /admin/label.
Notice the new AI icon on any labels that were AI-generated.
Hover over this label to see the tooltip message.

Things to check before submitting the PR

I've written a descriptive PR title.
I've added/updated comments for large or confusing blocks of code.
I've included before/after screenshots above.
I've asked for and included translations for any user facing text that was added or modified.
I've updated any logging. Clicks, keyboard presses, and other user interactions should be logged. If you're not sure how (or if you need to update the logging), ask Mikey. Then make sure the documentation on this wiki page is up to date for the logs you added/updated.
I've tested on mobile (only needed for validation page).

…logic to check SQL tables. Added a tooltip message that pops up on hover across gallery, admin, and validate pages.

…AI icon.

misaugstad

Overall, this looks incredibly solid, great work!! Some comments:

Looks like when switching out the AI icon, something was missed on the /admin/label/ search page:
There are references to admin-ai-icon-header... Are those remnants of when you had an AI icon next to the label type name in the popup headers? If so, there's some stuff left to clean out there! If not, what does it do?
I didn't have a chance to carefully look through the three AiLabelIndicator.js files, but I assume that they have quite a bit of overlap. Do you think that it makes sense to try to consolidate them? We can talk in our meeting about how they're differentiated.
There are some more comments in the code, including some about writing more efficient queries!

misaugstad · 2025-12-12T18:16:56Z

app/models/label/LabelTable.scala

             at.stale,
-             comment.comments
+             comment.comments,
+             EXISTS (


I think that, instead of adding a subquery here, it would be more efficient to just do the joins in the main query. So within the query it would look like

... INNER JOIN sidewalk_user AS u ON at.user_id = u.user_id INNER JOIN user_role AS ur ON u.user_id = ur.user_id INNER JOIN role AS r ON ur.role_id = r.role_id INNER JOIN label_point AS lp ON lb1.label_id = lp.label_id ...

And then you could just refer to it as r.role = 'AI' rather than doing the subquery in the SELECT statement.

@misaugstad I removed the per-row EXISTS subquery in getRecentLabelsMetadata and pulled the role check into the main query: we now join user_role/role once and select (ai_user.user_id IS NOT NULL) AS ai_generated, using r.role = 'AI' from the join instead of a subquery.

misaugstad · 2025-12-12T18:19:44Z

app/models/label/LabelTable.scala

          if (includeAiTags) la.flatMap(_.tags).getOrElse(List.empty[String].bind).asColumnOf[Option[List[String]]]
-          else None.asInstanceOf[Option[List[String]]].asColumnOf[Option[List[String]]]
+          else None.asInstanceOf[Option[List[String]]].asColumnOf[Option[List[String]]],
+          isAiUser(l.userId)


The same comment above applies to these Slick queries as well. Rather than having this function that essentially creates a subquery for each row, we can do the joins above:

val _labelInfo = for { (_lb, _at, _us) <- labelsWithAuditTasksAndUserStats _ur <- userRoles if _us.userId === _ur.userId _r <- roleTable if _ur.roleId === _r.roleId ...

I would apply this to all the queries that you have, even if I didn't explicitly comment on them.

public/javascripts/Admin/src/Admin.Panorama.js

misaugstad · 2025-12-12T18:27:09Z

public/javascripts/Gallery/src/displays/ValidationInfoDisplay.js

            aiIcon.setAttribute('data-toggle', 'tooltip');
            aiIcon.setAttribute('data-placement', 'top');
-            aiIcon.setAttribute('title', i18next.t('common:ai-disclaimer', { aiVal: aiValidation }));
+            aiIcon.setAttribute('title', i18next.t('common:ai-generated-label-tooltip'));


I didn't test this change, but I'm assuming it's a mistake?

… fixed /admin/label/search icon issue, cleaned up code.

misaugstad

I'm looking at LabelMap, and this is not what the table was supposed to look like:

It used to look like this

Various comments throughout the code as well!

Gruntfile.js

app/models/label/LabelTable.scala

             at.stale,
-             comment.comments
+             comment.comments,
+             EXISTS (


app/models/label/LabelTable.scala

misaugstad · 2025-12-16T18:02:09Z

public/javascripts/Admin/src/Admin.GSVCommentView.js

    }

    function setLabel(labelMetadata) {
+        const isAiGenerated = Boolean(labelMetadata['ai_generated']);


I don't think that we should be using Boolean() here... I think that it's meant to coerce anything to a boolean primitive. But if our API is returning something other than a boolean primitive, then we have bigger problems and we shouldn't be hiding it like this.

But that's just based on my cursory googling, since I've never used the Boolean() function before. Did you have a reason for using it..?

@misaugstad I used Boolean() just to normalize potential null/undefined to a boolean when the field was missing, not because I expected non-boolean values. I agree we shouldn’t mask bad data - happy to drop the wrapper and rely on the API returning a real boolean. Let me switch it to use the value directly.

public/javascripts/Gallery/src/expandedview/ExpandedView.js

public/javascripts/Gallery/src/cards/CardContainer.js

public/javascripts/Gallery/src/expandedview/GalleryPanorama.js

public/javascripts/SVValidate/src/panorama/Panorama.js

public/javascripts/common/AiLabelIndicator.js

public/stylesheets/main.css

…ltip z-index, added comments, reordered AiLabelIndicator.js

app/models/label/LabelTable.scala

misaugstad · 2025-12-17T21:33:11Z

public/javascripts/Admin/src/Admin.GSVLabelView.js

        self.panorama.setPano(labelMetadata['gsv_panorama_id'], labelMetadata['heading'],
            labelMetadata['pitch'], labelMetadata['zoom'], panoCallback);

+        const isAiGenerated = Boolean(labelMetadata['ai_generated']);


You missed that you used Boolean() here. You should just be able to pass in labelMetadata['ai_generated'] directly to AdminPanoramaLabel() like we do for all the other parameters (you shouldn't need to check if it's equal to true either).

misaugstad · 2025-12-17T21:36:11Z

public/javascripts/Gallery/css/expanded-view.css

+    column-gap: 10px;
+}
+
+.gallery-expanded-view-header-label {


This CSS class isn't used anywhere, is it? I think that since you removed the icon from the header, all the edits from this file can likely be removed?

misaugstad · 2025-12-17T21:37:34Z

public/javascripts/Gallery/css/gallery.css

+.ai-icon-marker-expanded {
+    top: -6px;
+    left: -4px;
+}


Aaand just missing the newline here. Most minor thing in the world lol. But I would strongly recommend looking through the "Files changed" section of any PR before asking for reviews, since that's what the reviewers will be looking at! Will help you catch all sorts of mistakes

misaugstad · 2025-12-17T21:45:50Z

public/javascripts/SVValidate/src/label/Label.js

                setProperty("newTags", [...params.tags]); // Copy tags to newTags.
            }
            if ("ai_tags" in params) setAuditProperty("aiTags", params.ai_tags);
+            if ("ai_generated" in params) setAuditProperty("aiGenerated", Boolean(params.ai_generated));


Still using Boolean() here...

app/models/label/LabelTable.scala

misaugstad · 2026-01-08T23:05:01Z

@ishajagadish I've fixed the issue with the inner joins.

For the raw SQL query, the inner join worked as I had expected
For the Slick queries, for some reason Slick was generating a cross join when we tried to do the inner join at the place where we were. I was able to get around this by passing along _r.role === 'AI' instead of passing through the whole table. Not totally sure why that prevents Slick from creating a cross join that we don't need, but it worked!

I've fixed this in all four queries (Gallery, Validate, LabelMap, and the label popup).

Indicate AI-generated labels with AI icon on the label, with backend …

015b2e2

…logic to check SQL tables. Added a tooltip message that pops up on hover across gallery, admin, and validate pages.

misaugstad assigned misaugstad and ishajagadish Dec 11, 2025

misaugstad self-requested a review December 11, 2025 22:24

ishaj83 and others added 2 commits December 11, 2025 20:00

Made AI icon smaller and removed AI icon in header. Added new opaque …

dfd5984

…AI icon.

cleans up AI icon CSS a bit

a779a63

misaugstad requested changes Dec 12, 2025

View reviewed changes

Improved SQL queries, refactored AiLabelIndicator.js duplicate files,…

2d1f280

… fixed /admin/label/search icon issue, cleaned up code.

misaugstad requested changes Dec 16, 2025

View reviewed changes

Optimized SQL queries, fixed the LabelMap table popup, tweaked AI-too…

b160137

…ltip z-index, added comments, reordered AiLabelIndicator.js

misaugstad requested changes Dec 17, 2025

View reviewed changes

now using inner joins for checking if an AI user for our APIs

fc2baba

Added AI-generated label indicator and tooltip message #4094

Are you sure you want to change the base?

Added AI-generated label indicator and tooltip message #4094

Uh oh!

Conversation

ishajagadish commented Dec 11, 2025

Before/After screenshots

Testing instructions

Things to check before submitting the PR

Uh oh!

misaugstad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

misaugstad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

misaugstad commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants