-
Notifications
You must be signed in to change notification settings - Fork 27
Added AI-generated label indicator and tooltip message #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
015b2e2
dfd5984
a779a63
2d1f280
b160137
fc2baba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,13 @@ | |
| font-family: 'raleway-bold', sans-serif; | ||
| font-size: 1.5vw; | ||
| color: #2d2a3f; | ||
| display: flex; | ||
| align-items: center; | ||
| column-gap: 10px; | ||
| } | ||
|
|
||
| .gallery-expanded-view-header-label { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This CSS class isn't used anywhere, is it? I think that since you removed the icon from the header, all the edits from this file can likely be removed? |
||
| flex: 0 1 auto; | ||
| } | ||
|
|
||
| .gallery-expanded-view-pano { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -112,3 +112,22 @@ We should allow the pointer events to pass through and behave the same way as th | |
| .facial-feature { | ||
| fill: #2D2A3F; | ||
| } | ||
|
|
||
| .ai-icon-marker { | ||
| position: absolute; | ||
| width: clamp(12px, 0.75vw, 16px); | ||
| height: clamp(12px, 0.75vw, 16px); | ||
| z-index: 3; | ||
| pointer-events: auto; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .ai-icon-marker-card { | ||
| top: -6px; | ||
| left: -5px; | ||
| } | ||
|
|
||
| .ai-icon-marker-expanded { | ||
| top: -6px; | ||
| left: -4px; | ||
| } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aaand just missing the newline here. Most minor thing in the world lol. But I would strongly recommend looking through the "Files changed" section of any PR before asking for reviews, since that's what the reviewers will be looking at! Will help you catch all sorts of mistakes |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed that you used
Boolean()here. You should just be able to pass inlabelMetadata['ai_generated']directly toAdminPanoramaLabel()like we do for all the other parameters (you shouldn't need to check if it's equal totrueeither).