Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to pyo3 0.24 #34

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Bump to pyo3 0.24 #34

merged 5 commits into from
Mar 11, 2025

Conversation

kylebarron
Copy link
Contributor

Thank you for contributing to pyo3-async-runtimes!

Please consider adding the following to your pull request:

  • an entry in CHANGELOG.md
  • docs to all new functions and / or detail in the guide
  • tests for all new or changed functions

Be aware the CI pipeline will check your pull request for the following:

  • Rust tests (Just cargo test)
  • Rust lints (make clippy)
  • Rust formatting (cargo fmt)
  • Python formatting (black . --check. You can install black with pip install black)

@davidhewitt
Copy link
Member

Thanks, please add a changelog entry and then looks good to merge 👍

@kylebarron
Copy link
Contributor Author

Thanks, please add a changelog entry and then looks good to merge 👍

I looked for one, but I don't think there is a CHANGELOG.md file? Should we create one?

@davidhewitt
Copy link
Member

@kylebarron
Copy link
Contributor Author

Ah my fork was out of date

@kylebarron kylebarron mentioned this pull request Mar 11, 2025
@cjdsellers
Copy link
Collaborator

cjdsellers commented Mar 11, 2025

I see @kylebarron has added the changelog entry, the PR looks good and complete.

I'll keep the commit title for release in line with what @davidhewitt has been using.

Thanks everyone!

@cjdsellers cjdsellers merged commit c5a3746 into PyO3:main Mar 11, 2025
32 checks passed
@cjdsellers
Copy link
Collaborator

I see there's an additional step here, and we need to merge to a specific branch for the release.

On this occasion will let @davidhewitt take it from here when he can get to it.

@davidhewitt
Copy link
Member

Thanks all, release live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants