Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filename consistency in the sources #178

Closed
wants to merge 10 commits into from

Conversation

tgilon
Copy link
Contributor

@tgilon tgilon commented Feb 6, 2025

Changes proposed in this Pull Request

This PR proposes to improve the filename consistency in the sources, using the top-level folder as a reference.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@tgilon tgilon changed the title Improve file name consistency in the sources Improve filename consistency in the sources Feb 6, 2025
@tgilon tgilon marked this pull request as ready for review February 6, 2025 09:32
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkstrp
Copy link
Member

lkstrp commented Mar 6, 2025

This needs some wild merge conflict resolution and then is good to go @finozzifa ?

@finozzifa
Copy link
Contributor

finozzifa commented Mar 6, 2025

This needs some wild merge conflict resolution and then is good to go @finozzifa ?

Hi @lkstrp I guess so. I think we should ask @tgilon what his opinion is though.

Thanks!!!

@tgilon
Copy link
Contributor Author

tgilon commented Mar 10, 2025

@lkstrp I've fixed the conflicts

@lkstrp
Copy link
Member

lkstrp commented Mar 11, 2025

There is still a small pre-commit issue that cannot be resolved since you are merging from an org account, I think. Maybe something that makes sense to change in your org settings

@fneum fneum closed this in #189 Mar 11, 2025
@tgilon
Copy link
Contributor Author

tgilon commented Mar 11, 2025

There is still a small pre-commit issue that cannot be resolved since you are merging from an org account, I think. Maybe something that makes sense to change in your org settings

I've fixed it manually for now. I'll look into how to enable it.

@tgilon tgilon deleted the fix-fn-consistency branch March 11, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants