-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iron-air assumptions to be more conservative #179
Conversation
FYI @daniel-rdt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure the "docu/" prefix was intended.
It was to be consistent with #178. |
ready to merge from my side, but the CI needs a small fix |
I've fixed the test. @finozzifa Would it be possible to avoid this situation where adding a new manual input requires the test to be changed ? |
Changes proposed in this Pull Request
This PR proposes to improve iron-air assumptions (introduced in #149) using the same specification sheet as before, but using the upper bound instead of the midpoint for investment costs. We propose using 20$/kWh for instead of the previous 17.5$/kWh. The round trip efficiencies, fixed O&M costs and learning rates remain unchanged. They are all taken from the same specification sheet.
The values are manually converted to EUR 2023 and filled in the
inputs/manuals_inputs.csv
. The workflow updates them to EUR 2020.Assumptions
Checklist
doc
.environment.yaml
(if applicable).doc/release_notes.rst
of the upcoming release is included.