Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iron-air assumptions to be more conservative #179

Merged
merged 21 commits into from
Mar 11, 2025

Conversation

tgilon
Copy link
Contributor

@tgilon tgilon commented Feb 6, 2025

Changes proposed in this Pull Request

This PR proposes to improve iron-air assumptions (introduced in #149) using the same specification sheet as before, but using the upper bound instead of the midpoint for investment costs. We propose using 20$/kWh for instead of the previous 17.5$/kWh. The round trip efficiencies, fixed O&M costs and learning rates remain unchanged. They are all taken from the same specification sheet.

The values are manually converted to EUR 2023 and filled in the inputs/manuals_inputs.csv. The workflow updates them to EUR 2020.

Assumptions

  • All assumptions are taken from the specification sheet.
  • A premium of US$100/kW is assumed for Europe.
  • The assumed exchange rate is 1EUR = 1.05 USD.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@tgilon
Copy link
Contributor Author

tgilon commented Feb 6, 2025

FYI @daniel-rdt

Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure the "docu/" prefix was intended.

@tgilon
Copy link
Contributor Author

tgilon commented Mar 10, 2025

LGTM, not sure the "docu/" prefix was intended.

It was to be consistent with #178.

@tgilon
Copy link
Contributor Author

tgilon commented Mar 10, 2025

I've updated the assumptions for US data (removing the European premium). I've also merged master and two other PR (#187 and #178) to avoid further merge conflicts. Once merged, this PR will be clean and ready for review.

@tgilon tgilon marked this pull request as ready for review March 10, 2025 16:10
@fneum
Copy link
Member

fneum commented Mar 11, 2025

ready to merge from my side, but the CI needs a small fix

@tgilon
Copy link
Contributor Author

tgilon commented Mar 11, 2025

I've fixed the test.

@finozzifa Would it be possible to avoid this situation where adding a new manual input requires the test to be changed ?

@fneum fneum merged commit 4d11b7b into PyPSA:master Mar 11, 2025
3 checks passed
@tgilon tgilon deleted the update-iron-air branch March 11, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants