Exclude platformdirs 4.5.1 in GHA win jobs #3799
Open
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmundt
approved these changes
Dec 12, 2025
jsiirola
reviewed
Dec 12, 2025
.github/workflows/test_branches.yml
Outdated
| # as of 2025-12-12 | ||
| if test "${{matrix.TARGET}}" == 'win'; then | ||
| CONDA_DEPENDENCIES="$CONDA_DEPENDENCIES setuptools<74.0.0 platformdirs!=4.5.0" | ||
| CONDA_DEPENDENCIES="$CONDA_DEPENDENCIES setuptools<74.0.0 platformdirs<4.5.0" |
Member
There was a problem hiding this comment.
The only concern I have with this is we will never see if the issue is resolved (we will permanently be pinned before 4.5.0). I think I would prefer:
platformdirs!=4.5.0,!=4.5.1
(that's legal for pip... does it also work for conda?)
Member
Author
There was a problem hiding this comment.
Good point. I tried making that change and we'll see if conda is happy with it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3799 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 909 909
Lines 105579 105579
=======================================
Hits 94407 94407
Misses 11172 11172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blnicho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
A new version of platformdirs (4.5.1) is causing the win/3.13 GHA job to fail again. This is a continuation of the issue noted in #3770. This PR makes the pin on platformdirs more strict.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: