Skip to content

Exclude platformdirs 4.5.1 in GHA win jobs #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blnicho wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −4
Open

Exclude platformdirs 4.5.1 in GHA win jobs #3799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4669f89
Add stricter pin on platformdirs in GHA win jobs
blnicho Dec 12, 2025
3bc1db9
Exclude specific platformdirs versions instead of setting upper bound
blnicho Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/test_branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,10 @@ jobs:
echo "*** Install Pyomo dependencies ***"
# For windows, cannot use newer setuptools because of APPSI compilation issues
# There seems to be some specific problem with platformdirs 4.5.0
# on win 3.13/3.14 as of 2025-10-23
# on win 3.13/3.14 as of 2025-10-23 and platformdirs 4.5.1 on win/3.13
# as of 2025-12-12
if test "${{matrix.TARGET}}" == 'win'; then
CONDA_DEPENDENCIES="$CONDA_DEPENDENCIES setuptools<74.0.0 platformdirs!=4.5.0"
CONDA_DEPENDENCIES="$CONDA_DEPENDENCIES setuptools<74.0.0 platformdirs<4.5.0"
Copy link
Member

@jsiirola jsiirola Dec 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern I have with this is we will never see if the issue is resolved (we will permanently be pinned before 4.5.0). I think I would prefer:

platformdirs!=4.5.0,!=4.5.1

(that's legal for pip... does it also work for conda?)

Copy link
Member Author

@blnicho blnicho Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I tried making that change and we'll see if conda is happy with it.

fi
# Note: this will fail the build if any installation fails (or
# possibly if it outputs messages to stderr)
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/test_pr_and_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,10 @@ jobs:
echo "*** Install Pyomo dependencies ***"
# For windows, cannot use newer setuptools because of APPSI compilation issues
# There seems to be some specific problem with platformdirs 4.5.0
# on win 3.13/3.14 as of 2025-10-23
# on win 3.13/3.14 as of 2025-10-23 and platformdirs 4.5.1 on win/3.13
# as of 2025-12-12
if test "${{matrix.TARGET}}" == 'win'; then
CONDA_DEPENDENCIES="$CONDA_DEPENDENCIES setuptools<74.0.0 platformdirs!=4.5.0"
CONDA_DEPENDENCIES="$CONDA_DEPENDENCIES setuptools<74.0.0 platformdirs<4.5.0"
fi
# Note: this will fail the build if any installation fails (or
# possibly if it outputs messages to stderr)
Expand Down
Loading