Conversation
| scope: Option<PyPassScope>, | ||
| ) -> PyResult<()> { | ||
| let py_scope = scope.unwrap_or_default(); | ||
| let qsystem_pass = tket_qsystem::QSystemPass::default_with_scope(py_scope.scope) |
There was a problem hiding this comment.
One flag that's missing here is hide_funcs which is in the QSystemPass rust struct. We should also expose this to Python right? There is no corresponding "with" method that I'm aware of.
There was a problem hiding this comment.
That looks like an unintended omission.
Could you add a with_hide_funcs method, and propagate it here?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
Coverage 83.80% 83.81%
=======================================
Files 188 188
Lines 29035 29056 +21
Branches 27931 27931
=======================================
+ Hits 24334 24353 +19
- Misses 3539 3541 +2
Partials 1162 1162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return program | ||
|
|
||
|
|
||
| @dataclass |
There was a problem hiding this comment.
Since all parameters are boolean, let's mark them as kw_only to avoid someone calling QSystemPass(True, False, False, True).
| @dataclass | |
| @dataclass(kw_only=True) |
| scope: Option<PyPassScope>, | ||
| ) -> PyResult<()> { | ||
| let py_scope = scope.unwrap_or_default(); | ||
| let qsystem_pass = tket_qsystem::QSystemPass::default_with_scope(py_scope.scope) |
There was a problem hiding this comment.
That looks like an unintended omission.
Could you add a with_hide_funcs method, and propagate it here?
2 participants
closes #1553
Driveby: now ncludes a fix to how we resolve extensions in Python. See 076c176. Prior to this fix the transformed HUGR contained Custom ops rather than QSystem ops as we would expect.