-
Notifications
You must be signed in to change notification settings - Fork 16
feat: expose the QSystemPass to Python #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ddf8837
start binding the QSystemPasss
CalMacCQ 47fd2ae
add Python definition
CalMacCQ 72a7df2
add a test
CalMacCQ 0747f9e
add a test for a guppy generated hugr
CalMacCQ 076c176
fix: Use bundled extension registry when loading a CompilationState i…
aborgna-q 70557a8
add more assertions
CalMacCQ ca348e8
document Boolean args
CalMacCQ 739870d
add a with_hide_funcs method
CalMacCQ a20b808
Make QSystemPass a kw_only dataclass
CalMacCQ 63f3baa
Merge branch 'main' into cm/expose_qsystempass
CalMacCQ 5d8f28d
add missing docstring
CalMacCQ 89b8b66
fix bad wording
CalMacCQ a69f0cd
use new with_hide_funcs method in test to improve coverage
CalMacCQ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # /// script | ||
| # requires-python = ">=3.13" | ||
| # dependencies = [ | ||
| # "guppylang ==0.21.13", | ||
| # ] | ||
| # /// | ||
| from pathlib import Path | ||
| from sys import argv | ||
|
|
||
| from guppylang import guppy | ||
| from guppylang.std.quantum import qubit, h, cx, rz | ||
| from guppylang.std.angles import pi | ||
|
|
||
|
|
||
| @guppy | ||
| def flat_quantum_func(q0: qubit, q1: qubit) -> None: | ||
| h(q0) | ||
| rz(q0, 3 * pi / 4) | ||
| cx(q0, q1) | ||
|
|
||
|
|
||
| program = flat_quantum_func.compile_function() | ||
| Path(argv[0]).with_suffix(".hugr").write_bytes(program.to_bytes()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One flag that's missing here is
hide_funcswhich is in theQSystemPassrust struct. We should also expose this to Python right? There is no corresponding "with" method that I'm aware of.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like an unintended omission.
Could you add a
with_hide_funcsmethod, and propagate it here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in 739870d739870d. Do the docs make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM