fix rapids url #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #2. |
domcharrier
pushed a commit
that referenced
this pull request
Sep 5, 2024
In addition to
```
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
```
we add
```
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
```
This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %.
Verbose test output:
```cmake
36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure"
36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest
36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree
36: Start 1: test_bench
36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec
36: Start 2: nvbench_ctl
36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec
36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory
```
The respective code is in:
`testing/cmake/test_export/CMakeLists.txt`
This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing".
Very likely this has something to do with the remaining issue.
domcharrier
added a commit
that referenced
this pull request
Sep 6, 2024
In addition to
```
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
```
we add
```
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
```
This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %.
Verbose test output:
```cmake
36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure"
36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest
36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree
36: Start 1: test_bench
36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec
36: Start 2: nvbench_ctl
36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec
36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory
```
The respective code is in:
`testing/cmake/test_export/CMakeLists.txt`
This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing".
Very likely this has something to do with the remaining issue.
domcharrier
added a commit
that referenced
this pull request
Sep 6, 2024
In addition to
```
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
```
we add
```
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
```
This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %.
Verbose test output:
```cmake
36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure"
36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest
36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree
36: Start 1: test_bench
36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec
36: Start 2: nvbench_ctl
36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec
36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory
```
The respective code is in:
`testing/cmake/test_export/CMakeLists.txt`
This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing".
Very likely this has something to do with the remaining issue.
domcharrier
added a commit
that referenced
this pull request
Sep 6, 2024
monoatamd Tue Jun 4 16:01:27 2024 +0000 update ReadMe file monoatamd Wed May 8 12:08:04 2024 +0000 retain nvidia copyright line monoatamd Wed May 8 12:01:08 2024 +0000 update licenses monoatamd Tue May 7 16:51:29 2024 +0000 update linceses monoatamd Tue May 7 16:19:23 2024 +0000 update licnese monoatamd Tue May 7 15:49:14 2024 +0000 Remove CI related files. Need to port them later. monoatamd Tue May 7 15:46:06 2024 +0000 Remove a WAR that looked to work some time ago (<internal-link>) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit. monoatamd Tue May 7 15:16:41 2024 +0000 fix file extensions monoatamd Tue May 7 14:08:24 2024 +0000 rename file extensions to hip from cu.cpp monoatamd Tue May 7 12:49:50 2024 +0000 Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system. ADiL Wed Nov 22 12:58:24 2023 +0100 Merge pull request #5 from AMD-AI/fix/enable_different_host_compiler Enable different host compiler Philipp Samfass Fri Nov 10 01:45:00 2023 -0800 fix build of noisy bench Philipp Samfass Fri Nov 10 01:07:56 2023 -0800 let CMake decide which compiler to use for CXX files Philipp Samfass Fri Nov 10 00:57:18 2023 -0800 WIP: allow compiling host code without hipclang ADiL Fri Jun 16 16:56:34 2023 +0200 Merge pull request #3 from AMD-AI/feature/cmake Feature/cmake Philipp Samfass Wed Jun 14 13:46:32 2023 +0000 bugfix: fixed markdown output for HIP + fixed a few compiler warnings Philipp Samfass Tue Jun 13 12:17:51 2023 +0000 fix: delete move assignment as default assignment cannot be generated by hipcc Philipp Samfass Thu Jun 1 13:33:06 2023 +0200 bug: Mohammad and I found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks. monoatamd Wed May 31 10:21:46 2023 +0000 feat: Fix error about default move operator deleted monoatamd Tue May 30 08:07:35 2023 +0000 feat: Build tests/examples monoatamd Tue May 30 07:11:33 2023 +0000 feat: Adapt cmake files monoatamd Wed May 24 13:02:05 2023 +0000 feat: update cmake files and hipify tests/examples/sources reger-men Fri Feb 17 19:34:05 2023 +0100 initial Draft ADiL Tue Jan 24 13:51:06 2023 +0100 Merge pull request #2 from AMD-AI/add-license-2 Create LICENSE ADiL Tue Jan 24 13:50:51 2023 +0100 Create LICENSE ADiL Tue Jan 24 13:50:25 2023 +0100 Delete LICENSE ADiL Tue Jan 24 13:50:01 2023 +0100 Update README.md ADiL Tue Jan 24 13:47:57 2023 +0100 Merge pull request #1 from AMD-AI/add-license-1 Create LICENSE ADiL Tue Jan 24 13:47:41 2023 +0100 Create LICENSE ADiL Tue Jan 24 13:47:03 2023 +0100 Delete LICENSE ADiL Tue Jan 24 13:45:50 2023 +0100 Create LICENSE ADiL Tue Jan 24 13:45:02 2023 +0100 Delete LICENSE ADiL Tue Jan 24 13:44:28 2023 +0100 Update LICENSE ADiL Tue Jan 24 13:39:09 2023 +0100 Initial commit Co-authored-by: Mohammad Norouzi <[email protected]> Co-authored-by: Philipp Samfass <[email protected]> Co-authored-by: Adil Lashab <[email protected]> Co-authored-by: Dominic Etienne Charrier <[email protected]>
domcharrier
added a commit
that referenced
this pull request
Sep 6, 2024
In addition to
```
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
```
we add
```
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
```
This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %.
Verbose test output:
```cmake
36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure"
36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest
36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree
36: Start 1: test_bench
36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec
36: Start 2: nvbench_ctl
36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec
36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory
```
The respective code is in:
`testing/cmake/test_export/CMakeLists.txt`
This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing".
Very likely this has something to do with the remaining issue.
psamfass
pushed a commit
that referenced
this pull request
Sep 6, 2024
In addition to
```
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
```
we add
```
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
```
This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %.
Verbose test output:
```cmake
36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure"
36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest
36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree
36: Start 1: test_bench
36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec
36: Start 2: nvbench_ctl
36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec
36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory
```
The respective code is in:
`testing/cmake/test_export/CMakeLists.txt`
This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing".
Very likely this has something to do with the remaining issue.
psamfass
added a commit
that referenced
this pull request
Sep 6, 2024
monoatamd Tue Jun 4 16:01:27 2024 +0000 update ReadMe file monoatamd Wed May 8 12:08:04 2024 +0000 retain nvidia copyright line monoatamd Wed May 8 12:01:08 2024 +0000 update licenses monoatamd Tue May 7 16:51:29 2024 +0000 update linceses monoatamd Tue May 7 16:19:23 2024 +0000 update licnese monoatamd Tue May 7 15:49:14 2024 +0000 Remove CI related files. Need to port them later. monoatamd Tue May 7 15:46:06 2024 +0000 Remove a WAR that looked to work some time ago (<internal-link>) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit. monoatamd Tue May 7 15:16:41 2024 +0000 fix file extensions monoatamd Tue May 7 14:08:24 2024 +0000 rename file extensions to hip from cu.cpp monoatamd Tue May 7 12:49:50 2024 +0000 Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system. ADiL Wed Nov 22 12:58:24 2023 +0100 Merge pull request #5 from AMD-AI/fix/enable_different_host_compiler Enable different host compiler Philipp Samfass Fri Nov 10 01:45:00 2023 -0800 fix build of noisy bench Philipp Samfass Fri Nov 10 01:07:56 2023 -0800 let CMake decide which compiler to use for CXX files Philipp Samfass Fri Nov 10 00:57:18 2023 -0800 WIP: allow compiling host code without hipclang ADiL Fri Jun 16 16:56:34 2023 +0200 Merge pull request #3 from AMD-AI/feature/cmake Feature/cmake Philipp Samfass Wed Jun 14 13:46:32 2023 +0000 bugfix: fixed markdown output for HIP + fixed a few compiler warnings Philipp Samfass Tue Jun 13 12:17:51 2023 +0000 fix: delete move assignment as default assignment cannot be generated by hipcc Philipp Samfass Thu Jun 1 13:33:06 2023 +0200 bug: Mohammad and I found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks. monoatamd Wed May 31 10:21:46 2023 +0000 feat: Fix error about default move operator deleted monoatamd Tue May 30 08:07:35 2023 +0000 feat: Build tests/examples monoatamd Tue May 30 07:11:33 2023 +0000 feat: Adapt cmake files monoatamd Wed May 24 13:02:05 2023 +0000 feat: update cmake files and hipify tests/examples/sources reger-men Fri Feb 17 19:34:05 2023 +0100 initial Draft ADiL Tue Jan 24 13:51:06 2023 +0100 Merge pull request #2 from AMD-AI/add-license-2 Create LICENSE ADiL Tue Jan 24 13:50:51 2023 +0100 Create LICENSE ADiL Tue Jan 24 13:50:25 2023 +0100 Delete LICENSE ADiL Tue Jan 24 13:50:01 2023 +0100 Update README.md ADiL Tue Jan 24 13:47:57 2023 +0100 Merge pull request #1 from AMD-AI/add-license-1 Create LICENSE ADiL Tue Jan 24 13:47:41 2023 +0100 Create LICENSE ADiL Tue Jan 24 13:47:03 2023 +0100 Delete LICENSE ADiL Tue Jan 24 13:45:50 2023 +0100 Create LICENSE ADiL Tue Jan 24 13:45:02 2023 +0100 Delete LICENSE ADiL Tue Jan 24 13:44:28 2023 +0100 Update LICENSE ADiL Tue Jan 24 13:39:09 2023 +0100 Initial commit Co-authored-by: Mohammad Norouzi <[email protected]> Co-authored-by: Philipp Samfass <[email protected]> Co-authored-by: Adil Lashab <[email protected]> Co-authored-by: Dominic Etienne Charrier <[email protected]>
psamfass
pushed a commit
that referenced
this pull request
Sep 6, 2024
In addition to
```
-D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/"
```
we add
```
-D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/"
```
This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %.
Verbose test output:
```cmake
36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure"
36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest
36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree
36: Start 1: test_bench
36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec
36: Start 2: nvbench_ctl
36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec
36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory
```
The respective code is in:
`testing/cmake/test_export/CMakeLists.txt`
This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing".
Very likely this has something to do with the remaining issue.
domcharrier
added a commit
that referenced
this pull request
Dec 5, 2024
780ce92 'fix(type_axis.cxx): explicitly cast to size_t to avoid sign conversion warning' <> Tue Oct 29 08:58:25 2024 -0700 <> Philipp Samfass <[email protected]> 709d8c1 '+ versions.json: empty, allows updating via CI' <> Thu Sep 19 08:32:36 2024 +0000 <> domcharrier <[email protected]> * Allows to control dependencies from CI process. NOTE ("first to record wins"): "If a project is listed in multiple override files, the first file values will be used, and all later calls for that packaged will be ignored. This "first to record, wins" approach is used to match FetchContent, and allows parent projects to override child projects." 25c9cd6 'sync: use public rapids-cmake' <> Thu Sep 19 09:17:57 2024 +0000 <> domcharrier <[email protected]> Synchronize branch with public hipBench repo. 29ab10a 'doc(README.md): fix formatting of example output in README' <> Fri Sep 6 01:48:14 2024 -0700 <> Philipp Samfass <[email protected]> 9595076 'fix(testing/cm*/test*/CMakeLists.*):all tests pass' <> Thu Sep 5 19:30:18 2024 +0000 <> domcharrier <[email protected]> Reintroduce code that was removed during hipification process. Now all tests pass (assuming CMAKE_PREFIX_PATH contains the ROCm path). 095a5cc 'fix(testing/cmake/CMakeLists.txt): + libhipcxx_DIR' <> Thu Sep 5 18:51:11 2024 +0000 <> domcharrier <[email protected]> In addition to ``` -D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/" ``` we add ``` -D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/" ``` This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %. Verbose test output: ```cmake 36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure" 36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest 36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree 36: Start 1: test_bench 36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec 36: Start 2: nvbench_ctl 36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec 36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory ``` The respective code is in: `testing/cmake/test_export/CMakeLists.txt` This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing". Very likely this has something to do with the remaining issue. 3e5bee3 'fix(**Libhipcxx.cmake): use correct export sets' <> Thu Sep 5 18:35:26 2024 +0000 <> domcharrier <[email protected]> Use same sets as other targets: `nvbench-targets`. This fixes test `nvbench.test.cmake.test_export.build_tree` but not the last failing test `nvbench.test.cmake.test_export.install_tree`. 3e145ff 'fix(**CMakeLists.txt): HIP lang + CUDA=HIP archs' <> Thu Sep 5 18:33:00 2024 +0000 <> domcharrier <[email protected]> Use HIP lang instead of CUDA. Allow CMAKE_HIP_ARCHITECTURES and CMAKE_CUDA_ARCHITECTURES for specifying AMD GPUs. 197fd90 'update ReadMe file' <> Tue Jun 4 16:01:27 2024 +0000 <> monoatamd <[email protected]> 963e733 'retain nvidia copyright line' <> Wed May 8 12:08:04 2024 +0000 <> monoatamd <[email protected]> 82d9d4a 'update licenses' <> Wed May 8 12:01:08 2024 +0000 <> monoatamd <[email protected]> 2e857d6 'update linceses' <> Tue May 7 16:51:29 2024 +0000 <> monoatamd <[email protected]> 923f610 'update licnese' <> Tue May 7 16:19:23 2024 +0000 <> monoatamd <[email protected]> 6352fe2 'Remove CI related files. Need to port them later.' <> Tue May 7 15:49:14 2024 +0000 <> monoatamd <[email protected]> c20c71b 'Remove a WAR that looked to work some time ago (https://<redacted>hipBench/commit/6068389724a4bf427612c27ebbdd8b8ff23284ae) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit.' <> Tue May 7 15:46:06 2024 +0000 <> monoatamd <[email protected]> 42f7d9e 'fix file extensions' <> Tue May 7 15:16:41 2024 +0000 <> monoatamd <[email protected]> eb2993b 'rename file extensions to hip from cu.cpp' <> Tue May 7 14:08:24 2024 +0000 <> monoatamd <[email protected]> bf8ac78 'Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system.' <> Tue May 7 12:49:50 2024 +0000 <> monoatamd <[email protected]> 19671c5 'docfix(README.md): add required settings for CMAKE_PREFIX_PATH' <> Fri Sep 6 03:05:43 2024 -0700 <> Philipp Samfass <[email protected]> 3182a5f 'doc(README.md): revise README to include necessary information for HIP port' <> Fri Sep 6 01:24:18 2024 -0700 <> Philipp Samfass <[email protected]> 69b6372 'cleanup internal AMD links' <> Mon May 27 08:47:39 2024 -0700 <> reger-men <[email protected]> 39ccca3 'Merge pull request #5 from AMD-AI/fix/enable_different_host_compiler' <> Wed Nov 22 12:58:24 2023 +0100 <> ADiL <[email protected]> Enable different host compiler bac4c5d 'fix build of noisy bench' <> Fri Nov 10 01:45:00 2023 -0800 <> Philipp Samfass <[email protected]> b176c41 'let CMake decide which compiler to use for CXX files' <> Fri Nov 10 01:07:56 2023 -0800 <> Philipp Samfass <[email protected]> 4ba018a 'WIP: allow compiling host code without hipclang' <> Fri Nov 10 00:57:18 2023 -0800 <> Philipp Samfass <[email protected]> 631890f 'Merge pull request #3 from AMD-AI/feature/cmake' <> Fri Jun 16 16:56:34 2023 +0200 <> ADiL <[email protected]> Feature/cmake 3b5d413 'bugfix: fixed markdown output for HIP + fixed a few compiler warnings' <> Wed Jun 14 13:46:32 2023 +0000 <> Philipp Samfass <[email protected]> f81a324 'fix: delete move assignment as default assignment cannot be generated by hipcc' <> Tue Jun 13 12:17:51 2023 +0000 <> Philipp Samfass <[email protected]> 6068389 'bug: Mohammad and I found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks.' <> Thu Jun 1 13:33:06 2023 +0200 <> Philipp Samfass <[email protected]> cf59104 'feat: Fix error about default move operator deleted' <> Wed May 31 10:21:46 2023 +0000 <> monoatamd <[email protected]> 16d241f 'feat: Build tests/examples' <> Tue May 30 08:07:35 2023 +0000 <> monoatamd <[email protected]> c9eeaf2 'feat: Adapt cmake files' <> Tue May 30 07:11:33 2023 +0000 <> monoatamd <[email protected]> d6f8fea 'feat: update cmake files and hipify tests/examples/sources' <> Wed May 24 13:02:05 2023 +0000 <> monoatamd <[email protected]> 42d0f58 'initial Draft' <> Fri Feb 17 19:34:05 2023 +0100 <> reger-men <[email protected]> ec81e5c 'Merge pull request #2 from AMD-AI/add-license-2' <> Tue Jan 24 13:51:06 2023 +0100 <> ADiL <[email protected]> Create LICENSE dffabc6 'Create LICENSE' <> Tue Jan 24 13:50:51 2023 +0100 <> ADiL <[email protected]> ea8b0a3 'Delete LICENSE' <> Tue Jan 24 13:50:25 2023 +0100 <> ADiL <[email protected]> 0258699 'Update README.md' <> Tue Jan 24 13:50:01 2023 +0100 <> ADiL <[email protected]> a0c314a 'Merge pull request #1 from AMD-AI/add-license-1' <> Tue Jan 24 13:47:57 2023 +0100 <> ADiL <[email protected]> Create LICENSE ebfad50 'Create LICENSE' <> Tue Jan 24 13:47:41 2023 +0100 <> ADiL <[email protected]> ff1cea9 'Delete LICENSE' <> Tue Jan 24 13:47:03 2023 +0100 <> ADiL <[email protected]> 455535f 'Create LICENSE' <> Tue Jan 24 13:45:50 2023 +0100 <> ADiL <[email protected]> 09c0104 'Delete LICENSE' <> Tue Jan 24 13:45:02 2023 +0100 <> ADiL <[email protected]> 7f07e5f 'Update LICENSE' <> Tue Jan 24 13:44:28 2023 +0100 <> ADiL <[email protected]> Co-authored-by: psamfass <[email protected]> Co-authored-by: monoatamd <[email protected]> Co-authored-by: domcharrier <[email protected]> Co-authored-by: reger-men <[email protected]>
domcharrier
added a commit
that referenced
this pull request
Dec 5, 2024
4a2e88e 'add .gitignore' <> Mon Oct 28 19:36:25 2024 +0000 <> charlifu <[email protected]> Signed-off-by: charlifu <[email protected]> a5e1311 'fix(type_axis.cxx): explicitly cast to size_t to avoid sign conversion warning' <> Tue Oct 29 08:58:25 2024 -0700 <> Philipp Samfass <[email protected]> 1aa00cc '+ versions.json: empty, allows updating via CI' <> Thu Sep 19 08:32:36 2024 +0000 <> domcharrier <[email protected]> * Allows to control dependencies from CI process. NOTE ("first to record wins"): "If a project is listed in multiple override files, the first file values will be used, and all later calls for that packaged will be ignored. This "first to record, wins" approach is used to match FetchContent, and allows parent projects to override child projects." 73d4e9c 'sync: use public rapids-cmake' <> Thu Sep 19 09:17:57 2024 +0000 <> domcharrier <[email protected]> Synchronize branch with public hipBench repo. a684069 'doc(README.md): fix formatting of example output in README' <> Fri Sep 6 01:48:14 2024 -0700 <> Philipp Samfass <[email protected]> 3dde7a6 'fix(testing/cm*/test*/CMakeLists.*):all tests pass' <> Thu Sep 5 19:30:18 2024 +0000 <> domcharrier <[email protected]> Reintroduce code that was removed during hipification process. Now all tests pass (assuming CMAKE_PREFIX_PATH contains the ROCm path). c9594d4 'fix(testing/cmake/CMakeLists.txt): + libhipcxx_DIR' <> Thu Sep 5 18:51:11 2024 +0000 <> domcharrier <[email protected]> In addition to ``` -D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/" ``` we add ``` -D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/" ``` This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %. Verbose test output: ```cmake 36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure" 36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest 36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree 36: Start 1: test_bench 36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec 36: Start 2: nvbench_ctl 36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec 36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory ``` The respective code is in: `testing/cmake/test_export/CMakeLists.txt` This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing". Very likely this has something to do with the remaining issue. 650008b 'fix(**Libhipcxx.cmake): use correct export sets' <> Thu Sep 5 18:35:26 2024 +0000 <> domcharrier <[email protected]> Use same sets as other targets: `nvbench-targets`. This fixes test `nvbench.test.cmake.test_export.build_tree` but not the last failing test `nvbench.test.cmake.test_export.install_tree`. c82ec85 'fix(**CMakeLists.txt): HIP lang + CUDA=HIP archs' <> Thu Sep 5 18:33:00 2024 +0000 <> domcharrier <[email protected]> Use HIP lang instead of CUDA. Allow CMAKE_HIP_ARCHITECTURES and CMAKE_CUDA_ARCHITECTURES for specifying AMD GPUs. 301ca37 'update ReadMe file' <> Tue Jun 4 16:01:27 2024 +0000 <> monoatamd <[email protected]> 336f81e 'retain nvidia copyright line' <> Wed May 8 12:08:04 2024 +0000 <> monoatamd <[email protected]> 44e3b73 'update licenses' <> Wed May 8 12:01:08 2024 +0000 <> monoatamd <[email protected]> b5e7b3d 'update linceses' <> Tue May 7 16:51:29 2024 +0000 <> monoatamd <[email protected]> 42941e4 'update licnese' <> Tue May 7 16:19:23 2024 +0000 <> monoatamd <[email protected]> 8d8a210 'Remove CI related files. Need to port them later.' <> Tue May 7 15:49:14 2024 +0000 <> monoatamd <[email protected]> 28b7743 'Remove a WAR:' <> Tue May 7 15:46:06 2024 +0000 <> monoatamd <[email protected]> The WAR worked some time ago (https://<redacted>hipBench/commit/6068389724a4bf427612c27ebbdd8b8ff23284ae) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit. d66ea34 'fix file extensions' <> Tue May 7 15:16:41 2024 +0000 <> monoatamd <[email protected]> cc297cf 'rename file extensions to hip from cu.cpp' <> Tue May 7 14:08:24 2024 +0000 <> monoatamd <[email protected]> 34a5155 'Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system.' <> Tue May 7 12:49:50 2024 +0000 <> monoatamd <[email protected]> a57c0cf 'docfix(README.md): add required settings for CMAKE_PREFIX_PATH' <> Fri Sep 6 03:05:43 2024 -0700 <> Philipp Samfass <[email protected]> b13cf2f 'doc(README.md): revise README to include necessary information for HIP port' <> Fri Sep 6 01:24:18 2024 -0700 <> Philipp Samfass <[email protected]> 5fc4be9 'cleanup internal AMD links' <> Mon May 27 08:47:39 2024 -0700 <> reger-men <[email protected]> 4e391e7 'fix build of noisy bench' <> Fri Nov 10 01:45:00 2023 -0800 <> Philipp Samfass <[email protected]> 3d839b3 'let CMake decide which compiler to use for CXX files' <> Fri Nov 10 01:07:56 2023 -0800 <> Philipp Samfass <[email protected]> 487fa8d 'WIP: allow compiling host code without hipclang' <> Fri Nov 10 00:57:18 2023 -0800 <> Philipp Samfass <[email protected]> 42b8b99 'bugfix: fixed markdown output for HIP + fixed a few compiler warnings' <> Wed Jun 14 13:46:32 2023 +0000 <> Philipp Samfass <[email protected]> 21273d3 'fix: delete move assignment as default assignment cannot be generated by hipcc' <> Tue Jun 13 12:17:51 2023 +0000 <> Philipp Samfass <[email protected]> 7dfa4e5 'fix streams in state_generator' <> Thu Jun 1 13:33:06 2023 +0200 <> Philipp Samfass <[email protected]> We found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks. 00eecda 'feat: Fix error about default move operator deleted' <> Wed May 31 10:21:46 2023 +0000 <> monoatamd <[email protected]> 5857d5b 'feat: Build tests/examples' <> Tue May 30 08:07:35 2023 +0000 <> monoatamd <[email protected]> c0237aa 'feat: Adapt cmake files' <> Tue May 30 07:11:33 2023 +0000 <> monoatamd <[email protected]> b1b441c 'feat: update cmake files and hipify tests/examples/sources' <> Wed May 24 13:02:05 2023 +0000 <> monoatamd <[email protected]> 5944d9e 'initial Draft' <> Fri Feb 17 19:34:05 2023 +0100 <> reger-men <[email protected]> 4aadee4 'Create LICENSE' <> Tue Jan 24 13:50:51 2023 +0100 <> ADiL <[email protected]> f9aebd0 'Delete LICENSE' <> Tue Jan 24 13:50:25 2023 +0100 <> ADiL <[email protected]> 8e47637 'Update README.md' <> Tue Jan 24 13:50:01 2023 +0100 <> ADiL <[email protected]> ebfad50 'Create LICENSE' <> Tue Jan 24 13:47:41 2023 +0100 <> ADiL <[email protected]> ff1cea9 'Delete LICENSE' <> Tue Jan 24 13:47:03 2023 +0100 <> ADiL <[email protected]> 455535f 'Create LICENSE' <> Tue Jan 24 13:45:50 2023 +0100 <> ADiL <[email protected]> 09c0104 'Delete LICENSE' <> Tue Jan 24 13:45:02 2023 +0100 <> ADiL <[email protected]> 7f07e5f 'Update LICENSE' <> Tue Jan 24 13:44:28 2023 +0100 <> ADiL <[email protected]> Co-authored-by: psamfass <[email protected]> Co-authored-by: monoatamd <[email protected]> Co-authored-by: domcharrier <[email protected]> Co-authored-by: reger-men <[email protected]>
domcharrier
added a commit
that referenced
this pull request
Dec 12, 2024
38836c6 doc: add disclaimer <> Fri Dec 6 17:46:22 2024 +0100 <> Philipp Samfass <[email protected]> 4a2e88e add .gitignore <> Mon Oct 28 19:36:25 2024 +0000 <> charlifu <[email protected]> Signed-off-by: charlifu <[email protected]> a5e1311 fix(type_axis.cxx): explicitly cast to size_t to avoid sign conversion warning <> Tue Oct 29 08:58:25 2024 -0700 <> Philipp Samfass <[email protected]> 1aa00cc + versions.json: empty, allows updating via CI <> Thu Sep 19 08:32:36 2024 +0000 <> domcharrier <[email protected]> * Allows to control dependencies from CI process. NOTE ("first to record wins"): "If a project is listed in multiple override files, the first file values will be used, and all later calls for that packaged will be ignored. This "first to record, wins" approach is used to match FetchContent, and allows parent projects to override child projects." 73d4e9c sync: use public rapids-cmake <> Thu Sep 19 09:17:57 2024 +0000 <> domcharrier <[email protected]> Synchronize branch with public hipBench repo. a684069 doc(README.md): fix formatting of example output in README <> Fri Sep 6 01:48:14 2024 -0700 <> Philipp Samfass <[email protected]> 3dde7a6 fix(testing/cm*/test*/CMakeLists.*):all tests pass <> Thu Sep 5 19:30:18 2024 +0000 <> domcharrier <[email protected]> Reintroduce code that was removed during hipification process. Now all tests pass (assuming CMAKE_PREFIX_PATH contains the ROCm path). c9594d4 fix(testing/cmake/CMakeLists.txt): + libhipcxx_DIR <> Thu Sep 5 18:51:11 2024 +0000 <> domcharrier <[email protected]> In addition to ``` -D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/" ``` we add ``` -D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/" ``` This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %. Verbose test output: ```cmake 36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure" 36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest 36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree 36: Start 1: test_bench 36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec 36: Start 2: nvbench_ctl 36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec 36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory ``` The respective code is in: `testing/cmake/test_export/CMakeLists.txt` This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing". Very likely this has something to do with the remaining issue. 650008b fix(**Libhipcxx.cmake): use correct export sets <> Thu Sep 5 18:35:26 2024 +0000 <> domcharrier <[email protected]> Use same sets as other targets: `nvbench-targets`. This fixes test `nvbench.test.cmake.test_export.build_tree` but not the last failing test `nvbench.test.cmake.test_export.install_tree`. c82ec85 fix(**CMakeLists.txt): HIP lang + CUDA=HIP archs <> Thu Sep 5 18:33:00 2024 +0000 <> domcharrier <[email protected]> Use HIP lang instead of CUDA. Allow CMAKE_HIP_ARCHITECTURES and CMAKE_CUDA_ARCHITECTURES for specifying AMD GPUs. 301ca37 update ReadMe file <> Tue Jun 4 16:01:27 2024 +0000 <> monoatamd <[email protected]> 336f81e retain nvidia copyright line <> Wed May 8 12:08:04 2024 +0000 <> monoatamd <[email protected]> 44e3b73 update licenses <> Wed May 8 12:01:08 2024 +0000 <> monoatamd <[email protected]> b5e7b3d update linceses <> Tue May 7 16:51:29 2024 +0000 <> monoatamd <[email protected]> 42941e4 update licnese <> Tue May 7 16:19:23 2024 +0000 <> monoatamd <[email protected]> 8d8a210 Remove CI related files. Need to port them later. <> Tue May 7 15:49:14 2024 +0000 <> monoatamd <[email protected]> 28b7743 Remove a WAR: <> Tue May 7 15:46:06 2024 +0000 <> monoatamd <[email protected]> The WAR worked some time ago (https://<redacted>hipBench/commit/6068389724a4bf427612c27ebbdd8b8ff23284ae) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit. d66ea34 fix file extensions <> Tue May 7 15:16:41 2024 +0000 <> monoatamd <[email protected]> cc297cf rename file extensions to hip from cu.cpp <> Tue May 7 14:08:24 2024 +0000 <> monoatamd <[email protected]> 34a5155 Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system. <> Tue May 7 12:49:50 2024 +0000 <> monoatamd <[email protected]> a57c0cf docfix(README.md): add required settings for CMAKE_PREFIX_PATH <> Fri Sep 6 03:05:43 2024 -0700 <> Philipp Samfass <[email protected]> b13cf2f doc(README.md): revise README to include necessary information for HIP port <> Fri Sep 6 01:24:18 2024 -0700 <> Philipp Samfass <[email protected]> 4e391e7 fix build of noisy bench <> Fri Nov 10 01:45:00 2023 -0800 <> Philipp Samfass <[email protected]> 3d839b3 let CMake decide which compiler to use for CXX files <> Fri Nov 10 01:07:56 2023 -0800 <> Philipp Samfass <[email protected]> 487fa8d WIP: allow compiling host code without hipclang <> Fri Nov 10 00:57:18 2023 -0800 <> Philipp Samfass <[email protected]> 42b8b99 bugfix: fixed markdown output for HIP + fixed a few compiler warnings <> Wed Jun 14 13:46:32 2023 +0000 <> Philipp Samfass <[email protected]> 21273d3 fix: delete move assignment as default assignment cannot be generated by hipcc <> Tue Jun 13 12:17:51 2023 +0000 <> Philipp Samfass <[email protected]> 7dfa4e5 fix streams in state_generator <> Thu Jun 1 13:33:06 2023 +0200 <> Philipp Samfass <[email protected]> We found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks. 00eecda feat: Fix error about default move operator deleted <> Wed May 31 10:21:46 2023 +0000 <> monoatamd <[email protected]> 5857d5b feat: Build tests/examples <> Tue May 30 08:07:35 2023 +0000 <> monoatamd <[email protected]> c0237aa feat: Adapt cmake files <> Tue May 30 07:11:33 2023 +0000 <> monoatamd <[email protected]> b1b441c feat: update cmake files and hipify tests/examples/sources <> Wed May 24 13:02:05 2023 +0000 <> monoatamd <[email protected]> 4aadee4 Create LICENSE <> Tue Jan 24 13:50:51 2023 +0100 <> ADiL <[email protected]> f9aebd0 Delete LICENSE <> Tue Jan 24 13:50:25 2023 +0100 <> ADiL <[email protected]> 8e47637 Update README.md <> Tue Jan 24 13:50:01 2023 +0100 <> ADiL <[email protected]> ebfad50 Create LICENSE <> Tue Jan 24 13:47:41 2023 +0100 <> ADiL <[email protected]> ff1cea9 Delete LICENSE <> Tue Jan 24 13:47:03 2023 +0100 <> ADiL <[email protected]> 455535f Create LICENSE <> Tue Jan 24 13:45:50 2023 +0100 <> ADiL <[email protected]> 09c0104 Delete LICENSE <> Tue Jan 24 13:45:02 2023 +0100 <> ADiL <[email protected]> 7f07e5f Update LICENSE <> Tue Jan 24 13:44:28 2023 +0100 <> ADiL <[email protected]> Co-authored-by: psamfass <[email protected]> Co-authored-by: monoatamd <[email protected]> Co-authored-by: domcharrier <[email protected]> Co-authored-by: reger-men <[email protected]>
domcharrier
added a commit
that referenced
this pull request
Apr 24, 2025
e750bc0 bump minimum CMake version to 3.23 for rocm-ds-cmake compatibility <> Mon Apr 14 02:44:48 2025 -0700 <> Philipp Samfass <[email protected]> 8cb2b22 feat(*RapidsCMake.*): ROCm-DS_CMAKE_MODULE_PATH <> Mon Apr 14 06:25:37 2025 +0000 <> domcharrier <[email protected]> Change to ROCm-DS_CMAKE_MODULE_PATH from ROCm-DS_CMAKE_FROM_MODULE_PATH as this allows setting pointing to the ROCmDS-CMake module files via an environment variable, which in turn allows to inject this information easier into more complex build processes (scikit-build). 11072be cmake/tests/*:use nvbench:: tgts via hipbench pkg <> Tue Apr 1 13:25:42 2025 +0000 <> domcharrier <[email protected]> Add option `FIND_NVBENCH` to switch between the two packages provided by a hipbench installation. b1da144 feat(cmake): hipbench pkg provides nvbench:: too <> Tue Apr 1 13:24:13 2025 +0000 <> domcharrier <[email protected]> find_pacakge(hipbench) now also provides access to the `nvbench::` targets. 36ce614 cmake/tests: add test for find_package(hipbench) <> Fri Mar 28 13:41:46 2025 +0000 <> [email protected] <domcharrier> 5c26c6a cmake: export a hipbench package too <> Mon Mar 31 09:04:04 2025 +0000 <> [email protected] <domcharrier> 4f91ba5 feat(nvbench/CMake*.txt): add hipbench targets <> Mon Mar 31 08:55:29 2025 +0000 <> [email protected] <domcharrier> * Provide hipbench:: ALIAS targets for add_subdirectory type usage. * Create and install hipbench INTERFACE target that is linked with nvbench. 5eff081 CMakeLists.txt: disable installing CPM downloads <> Fri Mar 28 16:11:06 2025 +0000 <> [email protected] <domcharrier> Add option for disabling installation of packages downloaded by CPM. This won't affect packages that CPM has found locally as those are not installed in any case. Motivation: When creating packages, one might want to package/install the NVBench files in isolation and not install libhipcxx files. 759bfce feat(CMakeLists.txt): use packaging cmake module <> Fri Mar 28 11:24:49 2025 +0000 <> domcharrier <[email protected]> d394d2f + cmake/NVBenchPackaging.cmake: includes CPACK <> Fri Mar 28 11:24:18 2025 +0000 <> domcharrier <[email protected]> 935ee1f hotfix(NVBenchDependencies.cmake): use fmt version from ROCm-DS-cmake <> Wed Mar 26 02:49:13 2025 -0700 <> Philipp Samfass <[email protected]> Details: fmt 9.1.0 fails to compile with more recent gcc versions (observed with GCC 13.3.0). We now let rocm-ds-cmake pick the fmt version which in this case happens to be 10.* and which no longer suffers from the previously observed compiler error: ``` /home/sphilipp/hipBench/build/_deps/fmt-src/include/fmt/core.h:1735:15: error: possibly dangling reference to a temporary [-Werror=dangling-reference] 1735 | const auto& arg = arg_mapper<Context>().map(FMT_FORWARD(val)); | ^~~ /home/sphilipp/hipBench/build/_deps/fmt-src/include/fmt/core.h:1735:46: note: the temporary was destroyed at the end of the full expression 'fmt::v9::detail::arg_mapper<fmt::v9::basic_format_context<fmt::v9::appender, char> >().fmt::v9::detail::arg_mapper<fmt::v9::basic_format_context<fmt::v9::appender, char> >::map<std::vector<std::__cxx11::basic_string<char> >&>((* & val))' 1735 | const auto& arg = arg_mapper<Context>().map(FMT_FORWARD(val)); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ``` bd776c5 feat: +option to find ROCmDS-CMake on module path <> Tue Mar 18 18:20:23 2025 +0000 <> domcharrier <[email protected]> Adds an option ROCm-DS_CMAKE_FROM_MODULE_PATH [default=OFF] that disables fetching of ROCm-DS CMake script and repo assuming that ROCm-DS CMake modules can be found via the CMAKE_MODULE_PATH. 38836c6 doc: add disclaimer <> Fri Dec 6 17:46:22 2024 +0100 <> Philipp Samfass <[email protected]> 4a2e88e add .gitignore <> Mon Oct 28 19:36:25 2024 +0000 <> charlifu <[email protected]> Signed-off-by: charlifu <[email protected]> a5e1311 fix(type_axis.cxx): explicitly cast to size_t to avoid sign conversion warning <> Tue Oct 29 08:58:25 2024 -0700 <> Philipp Samfass <[email protected]> 1aa00cc + versions.json: empty, allows updating via CI <> Thu Sep 19 08:32:36 2024 +0000 <> domcharrier <[email protected]> * Allows to control dependencies from CI process. NOTE ("first to record wins"): "If a project is listed in multiple override files, the first file values will be used, and all later calls for that packaged will be ignored. This "first to record, wins" approach is used to match FetchContent, and allows parent projects to override child projects." 73d4e9c sync: use public rapids-cmake <> Thu Sep 19 09:17:57 2024 +0000 <> domcharrier <[email protected]> Synchronize branch with public hipBench repo. a684069 doc(README.md): fix formatting of example output in README <> Fri Sep 6 01:48:14 2024 -0700 <> Philipp Samfass <[email protected]> 3dde7a6 fix(testing/cm*/test*/CMakeLists.*):all tests pass <> Thu Sep 5 19:30:18 2024 +0000 <> domcharrier <[email protected]> Reintroduce code that was removed during hipification process. Now all tests pass (assuming CMAKE_PREFIX_PATH contains the ROCm path). c9594d4 fix(testing/cmake/CMakeLists.txt): + libhipcxx_DIR <> Thu Sep 5 18:51:11 2024 +0000 <> domcharrier <[email protected]> In addition to ``` -D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/" ``` we add ``` -D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/" ``` This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %. Verbose test output: ```cmake 36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure" 36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest 36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree 36: Start 1: test_bench 36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec 36: Start 2: nvbench_ctl 36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec 36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory ``` The respective code is in: `testing/cmake/test_export/CMakeLists.txt` This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing". Very likely this has something to do with the remaining issue. 650008b fix(**Libhipcxx.cmake): use correct export sets <> Thu Sep 5 18:35:26 2024 +0000 <> domcharrier <[email protected]> Use same sets as other targets: `nvbench-targets`. This fixes test `nvbench.test.cmake.test_export.build_tree` but not the last failing test `nvbench.test.cmake.test_export.install_tree`. c82ec85 fix(**CMakeLists.txt): HIP lang + CUDA=HIP archs <> Thu Sep 5 18:33:00 2024 +0000 <> domcharrier <[email protected]> Use HIP lang instead of CUDA. Allow CMAKE_HIP_ARCHITECTURES and CMAKE_CUDA_ARCHITECTURES for specifying AMD GPUs. 301ca37 update ReadMe file <> Tue Jun 4 16:01:27 2024 +0000 <> monoatamd <[email protected]> 336f81e retain nvidia copyright line <> Wed May 8 12:08:04 2024 +0000 <> monoatamd <[email protected]> 44e3b73 update licenses <> Wed May 8 12:01:08 2024 +0000 <> monoatamd <[email protected]> b5e7b3d update linceses <> Tue May 7 16:51:29 2024 +0000 <> monoatamd <[email protected]> 42941e4 update licnese <> Tue May 7 16:19:23 2024 +0000 <> monoatamd <[email protected]> 8d8a210 Remove CI related files. Need to port them later. <> Tue May 7 15:49:14 2024 +0000 <> monoatamd <[email protected]> 28b7743 Remove a WAR: <> Tue May 7 15:46:06 2024 +0000 <> monoatamd <[email protected]> The WAR worked some time ago (https://<redacted>hipBench/commit/6068389724a4bf427612c27ebbdd8b8ff23284ae) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit. d66ea34 fix file extensions <> Tue May 7 15:16:41 2024 +0000 <> monoatamd <[email protected]> cc297cf rename file extensions to hip from cu.cpp <> Tue May 7 14:08:24 2024 +0000 <> monoatamd <[email protected]> 34a5155 Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system. <> Tue May 7 12:49:50 2024 +0000 <> monoatamd <[email protected]> a57c0cf docfix(README.md): add required settings for CMAKE_PREFIX_PATH <> Fri Sep 6 03:05:43 2024 -0700 <> Philipp Samfass <[email protected]> b13cf2f doc(README.md): revise README to include necessary information for HIP port <> Fri Sep 6 01:24:18 2024 -0700 <> Philipp Samfass <[email protected]> 4e391e7 fix build of noisy bench <> Fri Nov 10 01:45:00 2023 -0800 <> Philipp Samfass <[email protected]> 3d839b3 let CMake decide which compiler to use for CXX files <> Fri Nov 10 01:07:56 2023 -0800 <> Philipp Samfass <[email protected]> 487fa8d WIP: allow compiling host code without hipclang <> Fri Nov 10 00:57:18 2023 -0800 <> Philipp Samfass <[email protected]> 42b8b99 bugfix: fixed markdown output for HIP + fixed a few compiler warnings <> Wed Jun 14 13:46:32 2023 +0000 <> Philipp Samfass <[email protected]> 21273d3 fix: delete move assignment as default assignment cannot be generated by hipcc <> Tue Jun 13 12:17:51 2023 +0000 <> Philipp Samfass <[email protected]> 7dfa4e5 fix streams in state_generator <> Thu Jun 1 13:33:06 2023 +0200 <> Philipp Samfass <[email protected]> We found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks. 00eecda feat: Fix error about default move operator deleted <> Wed May 31 10:21:46 2023 +0000 <> monoatamd <[email protected]> 5857d5b feat: Build tests/examples <> Tue May 30 08:07:35 2023 +0000 <> monoatamd <[email protected]> c0237aa feat: Adapt cmake files <> Tue May 30 07:11:33 2023 +0000 <> monoatamd <[email protected]> Co-authored-by: obersteiner <[email protected]> Co-authored-by: psamfass <[email protected]> Co-authored-by: monoatamd <[email protected]> Co-authored-by: domcharrier <[email protected]> Co-authored-by: reger-men <[email protected]> Co-authored-by: dkbhaskaran <[email protected]>
domcharrier
added a commit
that referenced
this pull request
Apr 25, 2025
3b5ee46 NVBenchRapidsCMake*:configurable ROCm-DS.cmake repo <> Thu Apr 24 20:26:42 2025 +0000 <> domcharrier <[email protected]> Make the repository from which to obtain the ROCm-DS.cmake script configurable via the environment variable `ROCm-DS_CMAKE_SCRIPT_REPO`. e750bc0 bump minimum CMake version to 3.23 for rocm-ds-cmake compatibility <> Mon Apr 14 02:44:48 2025 -0700 <> Philipp Samfass <[email protected]> 8cb2b22 feat(*RapidsCMake.*): ROCm-DS_CMAKE_MODULE_PATH <> Mon Apr 14 06:25:37 2025 +0000 <> domcharrier <[email protected]> Change to ROCm-DS_CMAKE_MODULE_PATH from ROCm-DS_CMAKE_FROM_MODULE_PATH as this allows setting pointing to the ROCmDS-CMake module files via an environment variable, which in turn allows to inject this information easier into more complex build processes (scikit-build). 11072be cmake/tests/*:use nvbench:: tgts via hipbench pkg <> Tue Apr 1 13:25:42 2025 +0000 <> domcharrier <[email protected]> Add option `FIND_NVBENCH` to switch between the two packages provided by a hipbench installation. b1da144 feat(cmake): hipbench pkg provides nvbench:: too <> Tue Apr 1 13:24:13 2025 +0000 <> domcharrier <[email protected]> find_pacakge(hipbench) now also provides access to the `nvbench::` targets. 36ce614 cmake/tests: add test for find_package(hipbench) <> Fri Mar 28 13:41:46 2025 +0000 <> [email protected] <domcharrier> 5c26c6a cmake: export a hipbench package too <> Mon Mar 31 09:04:04 2025 +0000 <> [email protected] <domcharrier> 4f91ba5 feat(nvbench/CMake*.txt): add hipbench targets <> Mon Mar 31 08:55:29 2025 +0000 <> [email protected] <domcharrier> * Provide hipbench:: ALIAS targets for add_subdirectory type usage. * Create and install hipbench INTERFACE target that is linked with nvbench. 5eff081 CMakeLists.txt: disable installing CPM downloads <> Fri Mar 28 16:11:06 2025 +0000 <> [email protected] <domcharrier> Add option for disabling installation of packages downloaded by CPM. This won't affect packages that CPM has found locally as those are not installed in any case. Motivation: When creating packages, one might want to package/install the NVBench files in isolation and not install libhipcxx files. 759bfce feat(CMakeLists.txt): use packaging cmake module <> Fri Mar 28 11:24:49 2025 +0000 <> domcharrier <[email protected]> d394d2f + cmake/NVBenchPackaging.cmake: includes CPACK <> Fri Mar 28 11:24:18 2025 +0000 <> domcharrier <[email protected]> 935ee1f hotfix(NVBenchDependencies.cmake): use fmt version from ROCm-DS-cmake <> Wed Mar 26 02:49:13 2025 -0700 <> Philipp Samfass <[email protected]> Details: fmt 9.1.0 fails to compile with more recent gcc versions (observed with GCC 13.3.0). We now let rocm-ds-cmake pick the fmt version which in this case happens to be 10.* and which no longer suffers from the previously observed compiler error: ``` /home/sphilipp/hipBench/build/_deps/fmt-src/include/fmt/core.h:1735:15: error: possibly dangling reference to a temporary [-Werror=dangling-reference] 1735 | const auto& arg = arg_mapper<Context>().map(FMT_FORWARD(val)); | ^~~ /home/sphilipp/hipBench/build/_deps/fmt-src/include/fmt/core.h:1735:46: note: the temporary was destroyed at the end of the full expression 'fmt::v9::detail::arg_mapper<fmt::v9::basic_format_context<fmt::v9::appender, char> >().fmt::v9::detail::arg_mapper<fmt::v9::basic_format_context<fmt::v9::appender, char> >::map<std::vector<std::__cxx11::basic_string<char> >&>((* & val))' 1735 | const auto& arg = arg_mapper<Context>().map(FMT_FORWARD(val)); | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ ``` bd776c5 feat: +option to find ROCmDS-CMake on module path <> Tue Mar 18 18:20:23 2025 +0000 <> domcharrier <[email protected]> Adds an option ROCm-DS_CMAKE_FROM_MODULE_PATH [default=OFF] that disables fetching of ROCm-DS CMake script and repo assuming that ROCm-DS CMake modules can be found via the CMAKE_MODULE_PATH. 38836c6 doc: add disclaimer <> Fri Dec 6 17:46:22 2024 +0100 <> Philipp Samfass <[email protected]> 4a2e88e add .gitignore <> Mon Oct 28 19:36:25 2024 +0000 <> charlifu <[email protected]> Signed-off-by: charlifu <[email protected]> a5e1311 fix(type_axis.cxx): explicitly cast to size_t to avoid sign conversion warning <> Tue Oct 29 08:58:25 2024 -0700 <> Philipp Samfass <[email protected]> 1aa00cc + versions.json: empty, allows updating via CI <> Thu Sep 19 08:32:36 2024 +0000 <> domcharrier <[email protected]> * Allows to control dependencies from CI process. NOTE ("first to record wins"): "If a project is listed in multiple override files, the first file values will be used, and all later calls for that packaged will be ignored. This "first to record, wins" approach is used to match FetchContent, and allows parent projects to override child projects." 73d4e9c sync: use public rapids-cmake <> Thu Sep 19 09:17:57 2024 +0000 <> domcharrier <[email protected]> Synchronize branch with public hipBench repo. a684069 doc(README.md): fix formatting of example output in README <> Fri Sep 6 01:48:14 2024 -0700 <> Philipp Samfass <[email protected]> 3dde7a6 fix(testing/cm*/test*/CMakeLists.*):all tests pass <> Thu Sep 5 19:30:18 2024 +0000 <> domcharrier <[email protected]> Reintroduce code that was removed during hipification process. Now all tests pass (assuming CMAKE_PREFIX_PATH contains the ROCm path). c9594d4 fix(testing/cmake/CMakeLists.txt): + libhipcxx_DIR <> Thu Sep 5 18:51:11 2024 +0000 <> domcharrier <[email protected]> In addition to ``` -D "NVBench_DIR=${tmp_install_prefix}/lib/cmake/nvbench/" ``` we add ``` -D "libhipcxx_DIR=${tmp_install_prefix}/lib/rapids/cmake/libhipcxx/" ``` This fixes the last failing test `nvbench.test.cmake.test_export.install_tree` to 50 %. Verbose test output: ```cmake 36: Running test command: "/opt/conda/envs/cudf_dev/bin/ctest" "--output-on-failure" 36: Test command failed: /opt/conda/envs/cudf_dev/bin/ctest 36: Test project /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_export/install_tree 36: Start 1: test_bench 36: 1/2 Test #1: test_bench ....................... Passed 1.65 sec 36: Start 2: nvbench_ctl 36: 2/2 Test #2: nvbench_ctl ......................***Failed 0.00 sec 36: /home/mohammad/docharri/hipdf/DEPS/hipbench/build/testing/cmake/test_nvbench_install/bin/nvbench-ctl: error while loading shared libraries: libnvbench.so: cannot open shared object file: No such file or directory ``` The respective code is in: `testing/cmake/test_export/CMakeLists.txt` This file contains a section with the comment "# Setup LD_LIBRARY_PATH for testing". Very likely this has something to do with the remaining issue. 650008b fix(**Libhipcxx.cmake): use correct export sets <> Thu Sep 5 18:35:26 2024 +0000 <> domcharrier <[email protected]> Use same sets as other targets: `nvbench-targets`. This fixes test `nvbench.test.cmake.test_export.build_tree` but not the last failing test `nvbench.test.cmake.test_export.install_tree`. c82ec85 fix(**CMakeLists.txt): HIP lang + CUDA=HIP archs <> Thu Sep 5 18:33:00 2024 +0000 <> domcharrier <[email protected]> Use HIP lang instead of CUDA. Allow CMAKE_HIP_ARCHITECTURES and CMAKE_CUDA_ARCHITECTURES for specifying AMD GPUs. 301ca37 update ReadMe file <> Tue Jun 4 16:01:27 2024 +0000 <> monoatamd <[email protected]> 336f81e retain nvidia copyright line <> Wed May 8 12:08:04 2024 +0000 <> monoatamd <[email protected]> 44e3b73 update licenses <> Wed May 8 12:01:08 2024 +0000 <> monoatamd <[email protected]> b5e7b3d update linceses <> Tue May 7 16:51:29 2024 +0000 <> monoatamd <[email protected]> 42941e4 update licnese <> Tue May 7 16:19:23 2024 +0000 <> monoatamd <[email protected]> 8d8a210 Remove CI related files. Need to port them later. <> Tue May 7 15:49:14 2024 +0000 <> monoatamd <[email protected]> 28b7743 Remove a WAR: <> Tue May 7 15:46:06 2024 +0000 <> monoatamd <[email protected]> The WAR worked some time ago (https://<redacted>hipBench/commit/6068389724a4bf427612c27ebbdd8b8ff23284ae) and now caues an error: hipErrorInvalidDevice: invalid device ordinal. Also, enable some parts of the code which was disabled before in the same commit. d66ea34 fix file extensions <> Tue May 7 15:16:41 2024 +0000 <> monoatamd <[email protected]> cc297cf rename file extensions to hip from cu.cpp <> Tue May 7 14:08:24 2024 +0000 <> monoatamd <[email protected]> 34a5155 Code cleanup: remove unused (CUPTI AND NVML) files, delete MSVC related snippets in build system. <> Tue May 7 12:49:50 2024 +0000 <> monoatamd <[email protected]> a57c0cf docfix(README.md): add required settings for CMAKE_PREFIX_PATH <> Fri Sep 6 03:05:43 2024 -0700 <> Philipp Samfass <[email protected]> b13cf2f doc(README.md): revise README to include necessary information for HIP port <> Fri Sep 6 01:24:18 2024 -0700 <> Philipp Samfass <[email protected]> 4e391e7 fix build of noisy bench <> Fri Nov 10 01:45:00 2023 -0800 <> Philipp Samfass <[email protected]> 3d839b3 let CMake decide which compiler to use for CXX files <> Fri Nov 10 01:07:56 2023 -0800 <> Philipp Samfass <[email protected]> 487fa8d WIP: allow compiling host code without hipclang <> Fri Nov 10 00:57:18 2023 -0800 <> Philipp Samfass <[email protected]> 42b8b99 bugfix: fixed markdown output for HIP + fixed a few compiler warnings <> Wed Jun 14 13:46:32 2023 +0000 <> Philipp Samfass <[email protected]> 21273d3 fix: delete move assignment as default assignment cannot be generated by hipcc <> Tue Jun 13 12:17:51 2023 +0000 <> Philipp Samfass <[email protected]> 7dfa4e5 fix streams in state_generator <> Thu Jun 1 13:33:06 2023 +0200 <> Philipp Samfass <[email protected]> We found that the streams are not necessarily created on the device on which they will be used. Therefore, we set the correct device with device->set_active before creating the state (which in turn creates the stream). This also seems to fix timeout warnings we have seen in some benchmarks. 00eecda feat: Fix error about default move operator deleted <> Wed May 31 10:21:46 2023 +0000 <> monoatamd <[email protected]> 5857d5b feat: Build tests/examples <> Tue May 30 08:07:35 2023 +0000 <> monoatamd <[email protected]> c0237aa feat: Adapt cmake files <> Tue May 30 07:11:33 2023 +0000 <> monoatamd <[email protected]> Co-authored-by: psamfass <[email protected]> Co-authored-by: monoatamd <[email protected]> Co-authored-by: domcharrier <[email protected]> Co-authored-by: reger-men <[email protected]> Co-authored-by: dkbhaskaran <[email protected]> Co-authored-by: charlifu <[email protected]> Co-authored-by: obersteiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
nvBench will be used as a submodule of top-level cmake projects:
So we need to make sure thirdparty dependencies are visible to all users.
We found original link is ristricted to AMD-AI users. This is not the right option. And should be fixed
Test