Skip to content

Crash fix on iOS when shaders are enabled #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrentDaMage merged 3 commits into from
Jan 4, 2026
Merged

Crash fix on iOS when shaders are enabled #246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1315c41
crash fix on iOS
Un1q32 Jan 4, 2026
2473bbb
target_compile_definitions
Un1q32 Jan 4, 2026
894efc1
make all these public
Un1q32 Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,13 +458,13 @@ message(STATUS "Selected GFX API: ${REMCPE_GFX_API}")

# OGL Shader variant build hack
if(REMCPE_GFX_API STREQUAL "OGL_SHADERS")
target_compile_options(reminecraftpe-core PRIVATE -DFEATURE_GFX_SHADERS)
target_compile_definitions(reminecraftpe-core PUBLIC FEATURE_GFX_SHADERS)
unset(REMCPE_GFX_API CACHE)
set(REMCPE_GFX_API "OGL" CACHE STRING "HAL GFX API")
endif()

if(REMCPE_GFX_API STREQUAL "OGL")
target_compile_options(reminecraftpe-core PRIVATE -DMCE_GFX_API_OGL=1)
target_compile_definitions(reminecraftpe-core PUBLIC MCE_GFX_API_OGL=1)
target_sources(reminecraftpe-core PRIVATE
renderer/hal/ogl/API_OGL.cpp
renderer/hal/ogl/BlendStateOGL.cpp
Expand Down Expand Up @@ -492,7 +492,7 @@ if(REMCPE_GFX_API STREQUAL "OGL")
renderer/platform/ogl/ShaderPrecision.cpp
)
elseif(REMCPE_GFX_API STREQUAL "D3D11")
target_compile_options(reminecraftpe-core PRIVATE -DMCE_GFX_API_D3D11=1 -DFEATURE_GFX_SHADERS)
target_compile_definitions(reminecraftpe-core PUBLIC MCE_GFX_API_D3D11=1 FEATURE_GFX_SHADERS)
target_sources(reminecraftpe-core PRIVATE
renderer/hal/d3d11/API_D3D11.cpp
renderer/hal/d3d11/BlendStateD3D11.cpp
Expand All @@ -518,7 +518,7 @@ elseif(REMCPE_GFX_API STREQUAL "D3D11")
renderer/hal/dxgi/helpers/TextureHelperDXGI.cpp
)
elseif((NOT DEFINED REMCPE_GFX_API) OR (REMCPE_GFX_API STREQUAL "Null"))
target_compile_options(reminecraftpe-core PRIVATE -DMCE_GFX_API_NULL=1)
target_compile_definitions(reminecraftpe-core PUBLIC MCE_GFX_API_NULL=1)
target_sources(reminecraftpe-core PRIVATE
renderer/hal/null/BlendStateNull.cpp
renderer/hal/null/BufferNull.cpp
Expand Down