-
Notifications
You must be signed in to change notification settings - Fork 48
Cherry-pick: Change test_common_templates_data_volumes.py sc to be dynamic (PR #1641) #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cnv-4.99
Are you sure you want to change the base?
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D/S test tox -e verify-bugs-are-open
failed: cnv-tests-tox-executor/16779
/lgtm |
🍒 Automated Cherry-pick from PR
This PR contains the cherry-pick of PR #1641 from
RoniKishner/openshift-virtualization-tests
.Original PR: Change test_common_templates_data_volumes.py sc to be dynamic
Author: @RoniKishner
Merge Commit: 14a4f05
The cherry-pick was applied cleanly to
cnv-4.99
without conflicts.Original PR Link: #1641
Original Commit: 14a4f05
Original PR Description
Short description:
Update the storage class used in
test_common_templates_data_volumes.py
to be dynamic according to global_configMore details:
The current test uses constant storage classes, this changes the storage classes to be dynamic according to the used global_config file.
Added a QUARANTINED on test_vm_from_data_source_missing_default_storage_class
What this PR does / why we need it:
Allow the test to run on different clusters without specific storage classes
*Some global configs only have 1 storage class defined in storage_class_matrix. in those the test will use the default (same) storage class.
Summary by CodeRabbit