fix: resolve binary tools detection after PyInstaller packaging#317
Open
bob-zebedy wants to merge 2 commits intoRfidResearchGroup:mainfrom
Open
fix: resolve binary tools detection after PyInstaller packaging#317bob-zebedy wants to merge 2 commits intoRfidResearchGroup:mainfrom
bob-zebedy wants to merge 2 commits intoRfidResearchGroup:mainfrom
Conversation
This fixes the warning about missing tools after PyInstaller packaging by correctly detecting the temporary extraction directory (sys._MEIPASS) in frozen environments. - New get_resource_dir() in chameleon_utils.py - Import default_cwd in chameleon_cli_unit.py - Simplify check_tools() to use imported default_cwd
|
You are welcome to add an entry to the CHANGELOG.md as well |
Built artifacts for commit 301fdb2FirmwareClient |
GameTec-live
added
the
testme!
LupusE
approved these changes
Feb 2, 2026
Contributor
LupusE
left a comment
LupusE
left a comment
There was a problem hiding this comment.
Does not break other components. I have not tested the pyinstaller myself, but looks reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the warning about missing tools after PyInstaller
packaging by correctly detecting the temporary
extraction directory (sys._MEIPASS) in frozen environments.
New get_resource_dir() in chameleon_utils.py
Import default_cwd in chameleon_cli_unit.py
Simplify check_tools() to use imported default_cwd