Fix CI (step from Eigen3 to Eigen5) #430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OSEST_PRIMAL_FEASIBLE
…h intern skipping of large problems, to avoid useless computations (adapt from Eigen 3 to Eigen5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the change of Eigen version (from Eigen3 to Eigen5).
The fixes are:
(1): Unit test:
ProxQP::dense: test primal infeasibility solving: From failed to solved.(2): Unit tests:
dense maros meszaros using the apiandsparse maros meszaros using the API: Fix long run_time.The commits:
(1): Commit 5ae94fb corrects the status update (
PROXQP_SOLVED_CLOSEST_PRIMAL_FEASIBLE) in the dense backend.(2): Commit da4a4b2 redefines the function
load_qp, in the Maros-Meszaros unit tests, to skip the large problems internally, and not after calling the function. With Eigen5, the complexity ofload_qpis linear w.r.t. the problem size, making the execution of the CI very long.