Skip to content

test: Add git env test util and tests for amend - #230

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/amendtest
Apr 28, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/amendtest

Conversation

@jerry-skydio

@jerry-skydio jerry-skydio commented Apr 17, 2026 •

Copy link
Copy Markdown
Collaborator

This should make it less likely for functionality to break

Fixes: #7

@jerry-skydio

jerry-skydio commented Apr 17, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
└#230 test: Add git env test util and tests for amend
 └#232 Add upload tests
  └#236 upload: Don't re-add assignees/reviewers that were removed
   └#238 upload: Add pr body source argument

@jerry-skydio

jerry-skydio commented Apr 17, 2026 •

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 3be3de55 d80fc364 diff Apr 17 15:17 PM 2 files changed, 904 insertions(+)
1 442d5dd1 d80fc364 diff Apr 21 16:46 PM 1 file changed, 18 insertions(+), 63 deletions(-)
2 d404edf8 d80fc364 diff Apr 21 16:47 PM 1 file changed, 6 insertions(+), 18 deletions(-)
3 52017799 4c8aee30 rebase Apr 21 17:07 PM 0 files changed
4 9aec3314 4c8aee30 diff Apr 21 17:11 PM 1 file changed, 2 insertions(+)
5 674e434d 4c8aee30 diff Apr 22 19:58 PM 1 file changed, 21 insertions(+), 26 deletions(-)
6 a969bc14 f28b9190 diff Apr 23 12:38 PM 1 file changed, 4 insertions(+), 4 deletions(-)
7 79f0363b e7e87173 diff Apr 23 15:01 PM 0 files changed
8 8b92128e a248a551 diff Apr 28 12:17 PM 1 file changed, 6 deletions(-)
9 e6a4cc88 a248a551 diff Apr 28 12:19 PM 1 file changed, 2 insertions(+)

@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/amendtest branch 3 times, most recently from d404edf to 5201779 Compare April 22, 2026 00:07
@jerry-skydio jerry-skydio mentioned this pull request Apr 22, 2026
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/amendtest branch 4 times, most recently from a969bc1 to 79f0363 Compare April 23, 2026 22:01
Comment thread tests/git_env.py
await self.sh.sh(self._git_path, "rev-parse", "--path-format=absolute", "--git-dir")
)[1].rstrip()
self.git_ctx.email = TEST_AUTHOR_EMAIL
self.git_ctx.author = TEST_AUTHOR_EMAIL.split("@")[0]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST_AUTHOR_NAME?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git_ctx.author actually doesn't correspond to git config user.name which is maybe weird -- its what's used for the first part of the branch prefix, so can't have spaces (unlike user.name)

This should make it less likely for functionality to break

Fixes: #7
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/amendtest branch from 79f0363 to 8b92128 Compare April 28, 2026 19:17
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/amendtest branch from 8b92128 to e6a4cc8 Compare April 28, 2026 19:19
@jerry-skydio
jerry-skydio merged commit d2421ad into main Apr 28, 2026
5 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/amendtest branch April 28, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revup test suite

3 participants