Skip to content

upload: Don't re-add assignees/reviewers that were removed - #236

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/noforcereview
May 19, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/noforcereview

Conversation

@jerry-skydio

@jerry-skydio jerry-skydio commented Apr 23, 2026 •

Copy link
Copy Markdown
Collaborator

If an assignee/reviewer was removed intentionally, don't re-add them.
Add a --force-reviewers flag to bypass this that defaults to false

@jerry-skydio

jerry-skydio commented Apr 23, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
└#236 upload: Don't re-add assignees/reviewers that were removed
 └#238 upload: Add pr body source argument
  └#239 test: Add more tests for rebase functionality of upload
   └#246 Replace patch-id rebase detection with merge-tree comparison

@jerry-skydio

jerry-skydio commented Apr 23, 2026 •

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 7813d73b e7e87173 diff Apr 23 16:44 PM 3 files changed, 55 insertions(+)
1 1b50bf6b e7e87173 diff Apr 23 16:44 PM 0 files changed
2 6da080cd e7e87173 diff Apr 23 16:47 PM 3 files changed, 18 insertions(+), 13 deletions(-)
3 ae550a62 8ef07d58 rebase Apr 28 12:17 PM 0 files changed
4 44de8896 9cf38dc9 rebase Apr 28 12:19 PM 0 files changed
5 00e961df f7c9d0de rebase Apr 28 12:20 PM 0 files changed
6 74f99781 0ef7ecb0 diff Apr 28 12:33 PM 0 files changed
7 16ba2dc0 0ef7ecb0 diff Apr 28 12:39 PM 1 file changed, 4 insertions(+), 1 deletion(-)

@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/noforcereview branch from 7813d73 to 1b50bf6 Compare April 23, 2026 23:44
@jerry-skydio
jerry-skydio removed the request for review from aaron-skydio April 23, 2026 23:45
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/noforcereview branch 2 times, most recently from 6da080c to ae550a6 Compare April 28, 2026 19:17
@jerry-skydio
jerry-skydio changed the base branch from main to jerry/revup/main/uploadtest April 28, 2026 19:17
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/uploadtest branch from 8ef07d5 to 9cf38dc Compare April 28, 2026 19:19
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/noforcereview branch from ae550a6 to 44de889 Compare April 28, 2026 19:19
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/uploadtest branch from 9cf38dc to f7c9d0d Compare April 28, 2026 19:20
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/noforcereview branch from 44de889 to 00e961d Compare April 28, 2026 19:20
Base automatically changed from jerry/revup/main/uploadtest to main April 28, 2026 19:22
If an assignee/reviewer was removed intentionally, don't re-add them.
Add a --force-reviewers flag to bypass this that defaults to false
@jerry-skydio
jerry-skydio merged commit 80a9073 into main May 19, 2026
5 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/noforcereview branch May 19, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants