upload: Add --trim-tags=nonidentifying - #296
Merged
Merged
Conversation
Collaborator
Author
|
Reviews in this chain: |
Collaborator
Author
|
jerry-skydio
force-pushed
the
jerry/revup/main/trim-nonidentifying
branch
from
September 11, 2026 21:59
0e5c363 to
be99481
Compare
This was referenced Sep 11, 2026
aaron-skydio
approved these changes
Sep 11, 2026
jerry-skydio
force-pushed
the
jerry/revup/main/trim-nonidentifying
branch
2 times, most recently
from
September 15, 2026 21:05
54512ae to
285a1d7
Compare
Trimming every tag makes the pushed commits unusable for making the same pr again, since a cherry-pick of one no longer says which topic, branch or relative topic it belongs to. Trimming nothing leaves lines that stop mattering the moment the pr exists, since the forge remembers labels, reviewers and assignees once they've been set. Add a middle setting that only trims those, plus update-pr-body and any tag left with no value. --trim-tags now takes false, nonidentifying or true, and accepts the same values from config as before. The value is mandatory so that the flag never reads like a boolean, which would invite writing a topic name where the value goes. Tag line matching moves out of parse_commit_tags into match_commit_tag so the new trim can reuse the case and plural handling.
jerry-skydio
force-pushed
the
jerry/revup/main/trim-nonidentifying
branch
from
September 15, 2026 21:07
285a1d7 to
e9fd5a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trimming every tag makes the pushed commits unusable for making the same
pr again, since a cherry-pick of one no longer says which topic, branch
or relative topic it belongs to. Trimming nothing leaves lines that stop
mattering the moment the pr exists, since the forge remembers labels,
reviewers and assignees once they've been set.
Add a middle setting that only trims those, plus update-pr-body and any
tag left with no value. --trim-tags now takes false, nonidentifying or
true, and accepts the same values from config as before. The value is
mandatory so that the flag never reads like a boolean, which would
invite writing a topic name where the value goes.
Tag line matching moves out of parse_commit_tags into match_commit_tag
so the new trim can reuse the case and plural handling.