Skip to content

upload: Add --trim-tags=nonidentifying - #296

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/trim-nonidentifying
Sep 15, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/trim-nonidentifying

Conversation

@jerry-skydio

Copy link
Copy Markdown
Collaborator

Trimming every tag makes the pushed commits unusable for making the same
pr again, since a cherry-pick of one no longer says which topic, branch
or relative topic it belongs to. Trimming nothing leaves lines that stop
mattering the moment the pr exists, since the forge remembers labels,
reviewers and assignees once they've been set.

Add a middle setting that only trims those, plus update-pr-body and any
tag left with no value. --trim-tags now takes false, nonidentifying or
true, and accepts the same values from config as before. The value is
mandatory so that the flag never reads like a boolean, which would
invite writing a topic name where the value goes.

Tag line matching moves out of parse_commit_tags into match_commit_tag
so the new trim can reuse the case and plural handling.

@jerry-skydio

jerry-skydio commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
└#296 upload: Add --trim-tags=nonidentifying

@jerry-skydio

jerry-skydio commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 0e5c3632 8e33338d diff Sep 11 14:51 PM 6 files changed, 149 insertions(+), 39 deletions(-)
1 be994817 8e33338d diff Sep 11 14:59 PM 3 files changed, 12 insertions(+), 4 deletions(-)
2 54512aef 09ceb4dc diff Sep 15 13:20 PM 0 files changed
3 285a1d7a fb24bd7e diff Sep 15 14:05 PM 1 file changed, 2 insertions(+), 3 deletions(-)
4 e9fd5a7d fb24bd7e diff Sep 15 14:07 PM 1 file changed, 2 insertions(+), 5 deletions(-)

Comment thread revup/topic_stack.py Outdated
Base automatically changed from jerry/revup/main/draft-tag to main September 15, 2026 20:20
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/trim-nonidentifying branch 2 times, most recently from 54512ae to 285a1d7 Compare September 15, 2026 21:05
Trimming every tag makes the pushed commits unusable for making the same
pr again, since a cherry-pick of one no longer says which topic, branch
or relative topic it belongs to. Trimming nothing leaves lines that stop
mattering the moment the pr exists, since the forge remembers labels,
reviewers and assignees once they've been set.

Add a middle setting that only trims those, plus update-pr-body and any
tag left with no value. --trim-tags now takes false, nonidentifying or
true, and accepts the same values from config as before. The value is
mandatory so that the flag never reads like a boolean, which would
invite writing a topic name where the value goes.

Tag line matching moves out of parse_commit_tags into match_commit_tag
so the new trim can reuse the case and plural handling.
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/trim-nonidentifying branch from 285a1d7 to e9fd5a7 Compare September 15, 2026 21:07
@jerry-skydio
jerry-skydio merged commit a9ad3d2 into main Sep 15, 2026
5 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/trim-nonidentifying branch September 15, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants