Skip to content

upload: Add --draft-on-create-only - #297

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/draftcreat
Sep 15, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/draftcreat

Conversation

@jerry-skydio

Copy link
Copy Markdown
Collaborator

When set, the Draft: tag only applies when the pr is created, so a pr that
the user marks ready for review in github stays that way.

@jerry-skydio

jerry-skydio commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
└#297 upload: Add --draft-on-create-only
 └#298 upload: Add --deep-stack-draft
  └#299 upload: Pass pushed refs to the pre-upload command

@jerry-skydio

jerry-skydio commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 af43a3c3 0e5c3632 diff Sep 11 14:51 PM 5 files changed, 59 insertions(+), 3 deletions(-)
1 eb4c1134 8e33338d rebase Sep 11 14:58 PM 0 files changed
2 297d71c6 09ceb4dc diff Sep 15 13:20 PM 0 files changed

@jerry-skydio
jerry-skydio changed the base branch from jerry/revup/main/trim-nonidentifying to main September 11, 2026 21:58
@jerry-skydio
jerry-skydio changed the base branch from main to jerry/revup/main/draft-tag September 11, 2026 21:58
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/draftcreat branch from af43a3c to eb4c113 Compare September 11, 2026 21:58

@aaron-skydio aaron-skydio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we default this option on for revup users?

it seems like a good default, although how you want to think about backwards compatibility of options like this

Base automatically changed from jerry/revup/main/draft-tag to main September 15, 2026 20:20
When set, the Draft: tag only applies when the pr is created, so a pr that
the user marks ready for review in github stays that way.
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/draftcreat branch from eb4c113 to 297d71c Compare September 15, 2026 20:20
@jerry-skydio

Copy link
Copy Markdown
Collaborator Author

i'll defer changing it for everybody atm, we can't predict what the most common workflow for all users is. i think there could be points made for either side of this flag

@jerry-skydio
jerry-skydio merged commit fb24bd7 into main Sep 15, 2026
6 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/draftcreat branch September 15, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants