Skip to content

upload: Check pre_upload right after creating commits - #312

Merged
jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/complete
Oct 3, 2026
Merged

jerry-skydio merged 1 commit into
mainfrom
jerry/revup/main/complete

Conversation

@jerry-skydio

@jerry-skydio jerry-skydio commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

This gets us 2 things

  • dry-run now runs the pre upload command, which can be a useful way
    to run the preupload on all your topics (otherwise topics marked rebase
    aren't passed to the command)
  • the pre upload command will run before pausing and prompting the user.

@jerry-skydio

jerry-skydio commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author

Reviews in this chain:
└#312 upload: Check pre_upload right after creating commits

@jerry-skydio

jerry-skydio commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator Author
# head base diff date summary
0 290c50f2 21108398 diff Oct 1 18:17 PM 1 file changed, 5 insertions(+), 4 deletions(-)
1 d000a197 21108398 diff Oct 1 18:25 PM 1 file changed, 6 insertions(+), 6 deletions(-)

This gets us 2 things

- dry-run now runs the pre upload command, which can be a useful way
to run the preupload on all your topics (otherwise topics marked rebase
aren't passed to the command)
- the pre upload command will run before pausing and prompting the user.
@jerry-skydio jerry-skydio changed the title upload: Check pre_upload before the confirmation prompt upload: Check pre_upload right after creating commits Oct 2, 2026
@jerry-skydio
jerry-skydio force-pushed the jerry/revup/main/complete branch from 290c50f to d000a19 Compare October 2, 2026 01:25
@jerry-skydio
jerry-skydio merged commit eab4711 into main Oct 3, 2026
6 checks passed
@jerry-skydio
jerry-skydio deleted the jerry/revup/main/complete branch October 3, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants