Skip to content

upload: Check pre_upload right after creating commits #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerry-skydio merged 1 commit into from
Oct 3, 2026
Merged

upload: Check pre_upload right after creating commits #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions revup/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ async def run(

yield UploadPhase.COMMITS_CREATED, topics

if args.pre_upload and not args.no_verify:
ref_args = topics.get_pushed_ref_args()
if ref_args:
with get_console().status("Running pre-upload command"):
run_pre_upload(args.pre_upload, ref_args, git_ctx.repo_root)

if args.dry_run:
topics.print(not args.verbose)
return
Expand All @@ -127,17 +133,12 @@ async def run(
args.force_reviewers,
args.pr_body_source,
)

if not args.skip_confirm and topics.num_reviews_changed() > 0:
topics.print(not args.verbose)
if git_ctx.sh.wait_for_confirmation():
return

if args.pre_upload and not args.no_verify:
ref_args = topics.get_pushed_ref_args()
if ref_args:
with get_console().status("Running pre-upload command"):
run_pre_upload(args.pre_upload, ref_args, git_ctx.repo_root)

yield UploadPhase.READY_TO_PUSH, topics

if not skip_push:
Expand Down
Loading