-
Notifications
You must be signed in to change notification settings - Fork 240
Implement Add/SubtractRecording classes and +- operators #4238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
h-mayorquin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will make the data model more expressive. Some edge cases:
- Different number of segments.
- Different number of samples
- Different time parameters (either t_starts or explicit timestamps).
First 2 are enforced and will raise an error if different. Time params are not, but maybe we should? |
|
Yes, I think we should. |
|
Cool. |
Yes, in my first read I did not realize that this is done I am Ok with this. |
Something that's been on my todo list for a while.
This PR enables one to do
recording1 +/- recording2:)