Skip to content

Fix rp violations bug #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 3 commits into from
Jan 15, 2026
+4 −5
Merged

Fix rp violations bug #4292

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c589aa2
ensure compute_refrac_period_violations returns dict
chrishalcrow Jan 6, 2026
62b2a66
Merge branch 'SpikeInterface:main' into fix-rp-violations
chrishalcrow Jan 6, 2026
08cabd9
Merge branch 'main' into fix-rp-violations
alejoe91 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/spikeinterface/metrics/quality/misc_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,13 @@ def compute_refrac_period_violations(

res = namedtuple("rp_violations", ["rp_contamination", "rp_violations"])

if unit_ids is None:
unit_ids = sorting_analyzer.unit_ids

if not HAVE_NUMBA:
warnings.warn("Error: numba is not installed.")
warnings.warn("compute_refrac_period_violations cannot run without numba.")
return None
return {unit_id: np.nan for unit_id in unit_ids}

sorting = sorting_analyzer.sorting
fs = sorting_analyzer.sampling_frequency
Expand All @@ -338,9 +341,6 @@ def compute_refrac_period_violations(

spikes = sorting.to_spike_vector(concatenated=False)

if unit_ids is None:
unit_ids = sorting_analyzer.unit_ids

num_spikes = compute_num_spikes(sorting_analyzer)

t_c = int(round(censored_period_ms * fs * 1e-3))
Expand Down